From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED676A937 for ; Wed, 23 Aug 2023 05:10:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1825C433A9; Wed, 23 Aug 2023 05:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692767435; bh=t7MiNnA4SY2z7TGIpeZD9bcbTBQv6ro0RBJ+niZrsRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q/sc0PYvDtSji0SL8Z/AfybO/N0lQdy+8120P+25jaSWAWgsVrsnJQfczhuR0HSKE YTNvKVlu0BrYWrej3cui0zhGKYhaMvJopN1KSZxuoegkSAtvXmCFQiHY4gxMsoFfis eUPEcauBWS4XUykopFK6NgHkh8vRbtHddnl/A2vIMz72E0yPj5J6Bkx97mfRcAzAmD TCEOpMOxAwcRNaM7d68Z5w9DKFqN2ymfWDE8tv1/7GRnrZ8PxFmu/WAE4aQvmdkFTG sAmNXm1w/S5XAYZPr17luqUT5ppq+4aoyEAKWnYPlFRLGcbewVVq3cPFObt+cYh5UN VSuT0ZD6g+2fw== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Jiri Pirko , Shay Drory Subject: [net-next 10/15] net/mlx5: Return -EOPNOTSUPP in mlx5_devlink_port_fn_migratable_set() directly Date: Tue, 22 Aug 2023 22:10:07 -0700 Message-ID: <20230823051012.162483-11-saeed@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230823051012.162483-1-saeed@kernel.org> References: <20230823051012.162483-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jiri Pirko Instead of initializing "err" variable, just return "-EOPNOTSUPP" directly where it is needed. Signed-off-by: Jiri Pirko Reviewed-by: Shay Drory Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index 609605c42d6d..87cc6ad2e17f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c @@ -4309,7 +4309,7 @@ int mlx5_devlink_port_fn_migratable_set(struct devlink_port *port, bool enable, struct mlx5_vport *vport; void *query_ctx; void *hca_caps; - int err = -EOPNOTSUPP; + int err; esw = mlx5_devlink_eswitch_get(port->devlink); if (IS_ERR(esw)) @@ -4317,7 +4317,7 @@ int mlx5_devlink_port_fn_migratable_set(struct devlink_port *port, bool enable, if (!MLX5_CAP_GEN(esw->dev, migration)) { NL_SET_ERR_MSG_MOD(extack, "Device doesn't support migration"); - return err; + return -EOPNOTSUPP; } vport = mlx5_devlink_port_fn_get_vport(port, esw); -- 2.41.0