netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Donald Hunter <donald.hunter@gmail.com>, <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>, <linux-doc@vger.kernel.org>,
	Stanislav Fomichev <sdf@google.com>,
	"Arkadiusz Kubalewski" <arkadiusz.kubalewski@intel.com>,
	<donald.hunter@redhat.com>
Subject: Re: [PATCH net-next v4 02/12] doc/netlink: Add a schema for netlink-raw families
Date: Wed, 23 Aug 2023 18:45:32 -0700	[thread overview]
Message-ID: <20230823184532.7e606d33@kernel.org> (raw)
In-Reply-To: <57ed25b1-e00f-2601-fc76-1f9d19182915@intel.com>

On Wed, 23 Aug 2023 14:43:13 -0700 Jacob Keller wrote:
> > It's a good question. The schema definitions are currently strict
> > supersets of genetlink:
> > 
> > genetlink <= genetlink-c <= genetlink-legacy <= netlink-raw
> > 
> > As you noted below, there's only 2 additions needed for the netlink raw
> > families, protonum and mcast-group value.
> > 
> > I would be happy to change the description and other references to
> > genetlink in this spec, but I'd like to hear Jakub's thoughts about
> > minimal modification vs a more thorough rewording. Perhaps a middle
> > ground would be to extend the top-level description to say "genetlink or
> > raw netlink" and qualify that all mention of genetlink also applies to
> > raw netlink.
> > 
> > Either way, I just noticed that the schema $id does need to be updated.
> 
> Ok, ya lets wait for Jakub's opinion. I think the clarification would be
> good since at least conceptually genetlink is distinct to me from
> netlink raw, so it feels a bit weird.

Hm, no great choice here.

I feel like posterity may judge us if we don't clean up the genetlink
references so let's remove the most obvious ones.

description, name.description, delete version completely, narrow down
protocol to just netlink-raw. And I think that's it? The comments are
fine, IMO.

  reply	other threads:[~2023-08-24  1:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 11:41 [PATCH net-next v4 00/12] tools/net/ynl: Add support for netlink-raw families Donald Hunter
2023-08-23 11:41 ` [PATCH net-next v4 01/12] doc/netlink: Fix typo in genetlink-* schemas Donald Hunter
2023-08-23 19:29   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 02/12] doc/netlink: Add a schema for netlink-raw families Donald Hunter
2023-08-23 19:32   ` Jacob Keller
2023-08-23 21:19     ` Donald Hunter
2023-08-23 21:43       ` Jacob Keller
2023-08-24  1:45         ` Jakub Kicinski [this message]
2023-08-23 11:41 ` [PATCH net-next v4 03/12] doc/netlink: Update genetlink-legacy documentation Donald Hunter
2023-08-23 19:34   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 04/12] doc/netlink: Document the netlink-raw schema extensions Donald Hunter
2023-08-23 19:35   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 05/12] tools/ynl: Add mcast-group schema parsing to ynl Donald Hunter
2023-08-23 19:35   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 06/12] tools/net/ynl: Fix extack parsing with fixed header genlmsg Donald Hunter
2023-08-23 19:36   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 07/12] tools/net/ynl: Add support for netlink-raw families Donald Hunter
2023-08-23 19:37   ` Jacob Keller
2023-08-24  1:46   ` Jakub Kicinski
2023-08-23 11:41 ` [PATCH net-next v4 08/12] tools/net/ynl: Implement nlattr array-nest decoding in ynl Donald Hunter
2023-08-23 19:38   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 09/12] tools/net/ynl: Add support for create flags Donald Hunter
2023-08-23 19:39   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 10/12] doc/netlink: Add spec for rt addr messages Donald Hunter
2023-08-23 19:39   ` Jacob Keller
2023-08-23 11:42 ` [PATCH net-next v4 11/12] doc/netlink: Add spec for rt link messages Donald Hunter
2023-08-23 19:40   ` Jacob Keller
2023-08-23 11:42 ` [PATCH net-next v4 12/12] doc/netlink: Add spec for rt route messages Donald Hunter
2023-08-23 19:41   ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230823184532.7e606d33@kernel.org \
    --to=kuba@kernel.org \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=donald.hunter@redhat.com \
    --cc=edumazet@google.com \
    --cc=jacob.e.keller@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).