From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37A57F
	for <netdev@vger.kernel.org>; Thu, 24 Aug 2023 01:45:34 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F27DEC433C8;
	Thu, 24 Aug 2023 01:45:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1692841534;
	bh=+/Hf0DnTRX59DK/EfpsVNSyw0w2ZUHGIm2JKxrZQP40=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=SI/Fuj4s7oTqvUArGQyizY05SaKQUpwktdUuojC72Kul+NvLhGJaKB4mlE/tawwpR
	 E6+HE+9b5GHggfpXTEnkU3QihSi7XoTaEplra5EgTb3gbUGItNPAJaOzGUdI5TSA3u
	 Zt0dqGiAHDcA4xvFF890Erd54hU3dtrsNJ26TffqZzLwi9oyI3a6/DPf6aVu9fYKC0
	 wq++DJPOcXE8M4KLaaxk/B9VsR91g2qn1y1gerF85FVz5b4/g2VJdDiKoUy9K4wERk
	 /KIYQxtbTrFoc9KCxHtUjh9k+dImT+jfPOasqFOWXTCuDCNW3yDevf0ToVzKH20H60
	 McTG9P8c6FXXg==
Date: Wed, 23 Aug 2023 18:45:32 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Donald Hunter <donald.hunter@gmail.com>, <netdev@vger.kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, "Paolo Abeni" <pabeni@redhat.com>, Jonathan Corbet
 <corbet@lwn.net>, <linux-doc@vger.kernel.org>, Stanislav Fomichev
 <sdf@google.com>, "Arkadiusz Kubalewski" <arkadiusz.kubalewski@intel.com>,
 <donald.hunter@redhat.com>
Subject: Re: [PATCH net-next v4 02/12] doc/netlink: Add a schema for
 netlink-raw families
Message-ID: <20230823184532.7e606d33@kernel.org>
In-Reply-To: <57ed25b1-e00f-2601-fc76-1f9d19182915@intel.com>
References: <20230823114202.5862-1-donald.hunter@gmail.com>
	<20230823114202.5862-3-donald.hunter@gmail.com>
	<005940db-b7b6-c935-b16f-8106d3970b11@intel.com>
	<m2edjth2x2.fsf@gmail.com>
	<57ed25b1-e00f-2601-fc76-1f9d19182915@intel.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 23 Aug 2023 14:43:13 -0700 Jacob Keller wrote:
> > It's a good question. The schema definitions are currently strict
> > supersets of genetlink:
> > 
> > genetlink <= genetlink-c <= genetlink-legacy <= netlink-raw
> > 
> > As you noted below, there's only 2 additions needed for the netlink raw
> > families, protonum and mcast-group value.
> > 
> > I would be happy to change the description and other references to
> > genetlink in this spec, but I'd like to hear Jakub's thoughts about
> > minimal modification vs a more thorough rewording. Perhaps a middle
> > ground would be to extend the top-level description to say "genetlink or
> > raw netlink" and qualify that all mention of genetlink also applies to
> > raw netlink.
> > 
> > Either way, I just noticed that the schema $id does need to be updated.
> 
> Ok, ya lets wait for Jakub's opinion. I think the clarification would be
> good since at least conceptually genetlink is distinct to me from
> netlink raw, so it feels a bit weird.

Hm, no great choice here.

I feel like posterity may judge us if we don't clean up the genetlink
references so let's remove the most obvious ones.

description, name.description, delete version completely, narrow down
protocol to just netlink-raw. And I think that's it? The comments are
fine, IMO.