netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, Stanislav Fomichev <sdf@google.com>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	donald.hunter@redhat.com
Subject: Re: [PATCH net-next v4 07/12] tools/net/ynl: Add support for netlink-raw families
Date: Wed, 23 Aug 2023 18:46:03 -0700	[thread overview]
Message-ID: <20230823184603.7fda3b66@kernel.org> (raw)
In-Reply-To: <20230823114202.5862-8-donald.hunter@gmail.com>

On Wed, 23 Aug 2023 12:41:56 +0100 Donald Hunter wrote:
> +    def get_mcast_id(self, mcast_name, mcast_groups):
> +        if mcast_name not in mcast_groups:
> +            raise Exception(f'Multicast group "{mcast_name}" not present in the spec')
> +        return mcast_groups[mcast_name].value
> +

if you repost - missing extra empty line here

> +class GenlProtocol(NetlinkProtocol):
> +    def __init__(self, family_name):

  parent reply	other threads:[~2023-08-24  1:46 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 11:41 [PATCH net-next v4 00/12] tools/net/ynl: Add support for netlink-raw families Donald Hunter
2023-08-23 11:41 ` [PATCH net-next v4 01/12] doc/netlink: Fix typo in genetlink-* schemas Donald Hunter
2023-08-23 19:29   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 02/12] doc/netlink: Add a schema for netlink-raw families Donald Hunter
2023-08-23 19:32   ` Jacob Keller
2023-08-23 21:19     ` Donald Hunter
2023-08-23 21:43       ` Jacob Keller
2023-08-24  1:45         ` Jakub Kicinski
2023-08-23 11:41 ` [PATCH net-next v4 03/12] doc/netlink: Update genetlink-legacy documentation Donald Hunter
2023-08-23 19:34   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 04/12] doc/netlink: Document the netlink-raw schema extensions Donald Hunter
2023-08-23 19:35   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 05/12] tools/ynl: Add mcast-group schema parsing to ynl Donald Hunter
2023-08-23 19:35   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 06/12] tools/net/ynl: Fix extack parsing with fixed header genlmsg Donald Hunter
2023-08-23 19:36   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 07/12] tools/net/ynl: Add support for netlink-raw families Donald Hunter
2023-08-23 19:37   ` Jacob Keller
2023-08-24  1:46   ` Jakub Kicinski [this message]
2023-08-23 11:41 ` [PATCH net-next v4 08/12] tools/net/ynl: Implement nlattr array-nest decoding in ynl Donald Hunter
2023-08-23 19:38   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 09/12] tools/net/ynl: Add support for create flags Donald Hunter
2023-08-23 19:39   ` Jacob Keller
2023-08-23 11:41 ` [PATCH net-next v4 10/12] doc/netlink: Add spec for rt addr messages Donald Hunter
2023-08-23 19:39   ` Jacob Keller
2023-08-23 11:42 ` [PATCH net-next v4 11/12] doc/netlink: Add spec for rt link messages Donald Hunter
2023-08-23 19:40   ` Jacob Keller
2023-08-23 11:42 ` [PATCH net-next v4 12/12] doc/netlink: Add spec for rt route messages Donald Hunter
2023-08-23 19:41   ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230823184603.7fda3b66@kernel.org \
    --to=kuba@kernel.org \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=donald.hunter@redhat.com \
    --cc=edumazet@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).