netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	<pabeni@redhat.com>, <edumazet@google.com>, <razor@blackwall.org>,
	<jiri@nvidia.com>, <mlxsw@nvidia.com>
Subject: Re: [PATCH net] rtnetlink: Reject negative ifindexes in RTM_NEWLINK
Date: Wed, 23 Aug 2023 19:06:31 -0700	[thread overview]
Message-ID: <20230823190631.4297d08c@kernel.org> (raw)
In-Reply-To: <20230823064348.2252280-1-idosch@nvidia.com>

On Wed, 23 Aug 2023 09:43:48 +0300 Ido Schimmel wrote:
> Negative ifindexes are illegal, but the kernel does not validate the
> ifindex in the ancillary header of RTM_NEWLINK messages, resulting in
> the kernel generating a warning [1] when such an ifindex is specified.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Thanks!

  reply	other threads:[~2023-08-24  2:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23  6:43 [PATCH net] rtnetlink: Reject negative ifindexes in RTM_NEWLINK Ido Schimmel
2023-08-24  2:06 ` Jakub Kicinski [this message]
2023-08-24  8:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230823190631.4297d08c@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=idosch@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).