From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CA37100C1 for ; Thu, 24 Aug 2023 16:28:53 +0000 (UTC) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D3521BDC; Thu, 24 Aug 2023 09:28:18 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9087D1C0004; Thu, 24 Aug 2023 16:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1692894496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9vlV24O5RSLn9le+rax+GkVBvAuRn488qRP2ADPCZKQ=; b=hQiusfd0FQuOVDUCU52tli4u035fc/XjK+mJGsdYMY9Cc3jlsA7j174kFQm83u8uLS5LVi R7rizQ427/PCiDxMGgmb0iBT+lg/nBzDrjL03AwM7yqDCH+8J6Xti7h9QC7C1DCftFq+ri 8stj0LwVZ80zdVKPSbG4wPO4NVB9ezkC+sAlBD5qiMpyGz5nRPAfNO/mO0fBPb1Yo15VfX F30PM50FnMGe+GtDc9KNirwD6IlaXFWYp4gX1Bd4hZpqpMGgR6w5QRnjELrFg4jeKKEAar 4fgQJ8axYCldIIsn9lZN0tvBAMnVq+qlp6kPjF8rY3LGLhynkVas5PMk9I4e7A== Date: Thu, 24 Aug 2023 18:28:11 +0200 From: Herve Codina To: Rob Herring Cc: Christophe Leroy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v4 22/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Message-ID: <20230824182811.1f8eb0a2@bootlin.com> In-Reply-To: <20230821204929.GA2261144-robh@kernel.org> References: <7c67d590b13a889466f53edf94192bca3bf6ceec.1692376361.git.christophe.leroy@csgroup.eu> <20230821204929.GA2261144-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Rob, On Mon, 21 Aug 2023 15:49:29 -0500 Rob Herring wrote: > On Fri, Aug 18, 2023 at 06:39:16PM +0200, Christophe Leroy wrote: > > From: Herve Codina > > > > The Lantiq PEF2256 is a framer and line interface component designed to > > fulfill all required interfacing between an analog E1/T1/J1 line and the > > digital PCM system highway/H.100 bus. > > > > Signed-off-by: Herve Codina > > Signed-off-by: Christophe Leroy > > --- > > .../bindings/net/lantiq,pef2256.yaml | 219 ++++++++++++++++++ > > 1 file changed, 219 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml ... > > + '#framer-cells': > > Not a standard binding. Do you need provider specific variable number of > cells? For the PEF2256, I don't need it. It will be removed in the next iteration. > > > + const: 0 > > + ... > > + lantiq,channel-phase: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > > + default: 0 > > + description: > > Need '|' to preserve formatting Will be fixed in the next iteration. Best regards, Hervé