From: Jakub Kicinski <kuba@kernel.org>
To: "Drewek, Wojciech" <wojciech.drewek@intel.com>
Cc: "intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
"idosch@nvidia.com" <idosch@nvidia.com>
Subject: Re: [PATCH iwl-next v2] ice: Disable Cage Max Power override
Date: Fri, 25 Aug 2023 17:54:56 -0700 [thread overview]
Message-ID: <20230825175456.44051773@kernel.org> (raw)
In-Reply-To: <MW4PR11MB57768054635E8DEF841BB2A9FDE3A@MW4PR11MB5776.namprd11.prod.outlook.com>
On Fri, 25 Aug 2023 11:01:07 +0000 Drewek, Wojciech wrote:
> > Can you say more? We have ETHTOOL_MSG_MODULE_GET / SET, sounds like
> > something we could quite easily get ethtool to support?
>
> So you're suggesting that ethtool could support setting the maximum power in the cage?
> Something like:
> - new "--set-module" parameter called "power-max"
> - new "--get-module" parameters: "power-max-allowed",
> "power-min-allowed" indicating limitations reported by the HW.
Yup. Oh, nice you even CCed Ido already :)
> About the patch itself, it's only about restoration of the default
> settings upon port split. Those might be overwritten by Intel's
> external tools.
I guess, the thing that sent me down the path of putting the control
in hands of the user more directly was the question of "why do we need
to reset on port split"? Why is that a policy the driver is supposed
to follow?
next prev parent reply other threads:[~2023-08-26 0:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 8:54 [PATCH iwl-next v2] ice: Disable Cage Max Power override Wojciech Drewek
2023-08-24 9:38 ` Przemek Kitszel
2023-08-24 15:32 ` Jakub Kicinski
2023-08-25 11:01 ` Drewek, Wojciech
2023-08-26 0:54 ` Jakub Kicinski [this message]
2023-08-27 8:47 ` Ido Schimmel
2023-08-29 9:12 ` Drewek, Wojciech
2023-08-30 15:17 ` Ido Schimmel
2023-09-01 13:34 ` Drewek, Wojciech
2023-09-12 14:26 ` Ido Schimmel
2023-09-15 13:15 ` Drewek, Wojciech
2023-09-21 12:09 ` Ido Schimmel
2023-10-05 13:58 ` [Intel-wired-lan] " Drewek, Wojciech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825175456.44051773@kernel.org \
--to=kuba@kernel.org \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).