Re: [PATCH 2/4] dt-bindings: net: dsa: document internal MDIO bus

Arınç ÜNAL
2023-09-12T19:24:04Z

On 12.09.2023 01:51, Vladimir Oltean wrote:
> On Sat, Sep 09, 2023 at 11:53:50AM +0300, Arınç ÜNAL wrote:
>> What to do:
>> - For mscc,vsc7514-switch, enforce phylink bindings for ports.
>> - For mscc,vsc7512-switch, enforce phylink bindings for user ports.
>
> you can also look at dsa_switches_apply_workarounds[], and if the switch
> isn't there, then you can replace "user ports" with "ports" here and
> everywhere.

The phylink bindings for user ports I ended up making by looking up the
existing devicetrees are different than the phylink bindings for the
shared (CPU and DSA) ports currently enforced on all switches.

My phylink bindings for user ports:

allOf:
- anyOf:
- required: [ fixed-link ]
- required: [ phy-handle ]
- required: [ managed ]

- if:
required: [ fixed-link ]
then:
not:
required: [ managed ]

The phylink bindings for shared ports enforced on all switches on
dsa-port.yaml:

allOf:
- required:
- phy-mode
- oneOf:
- required:
- fixed-link
- required:
- phy-handle
- required:
- managed

Here's what I understand:

- For switches in dsa_switches_apply_workarounds[]
- Enforce the latter for shared ports.
- Enforce the former for user ports.

- For switches not in dsa_switches_apply_workarounds[]
- Enforce the former for all ports.

>
>> - renesas,rzn1-a5psw.yaml
>> - renesas,r9a06g032-a5psw, renesas,rzn1-a5psw
>>
>> What to do:
>> - Document "mdio".
>
> Not clear here and for all the schemas quoted below.. is "mdio" not documented already?

They are, or rather I didn't care while constructing this text. I will
mention "mdio" is already documented per schema on the patch log.

Arınç