Re: [PATCH 2/4] dt-bindings: net: dsa: document internal MDIO bus

Vladimir Oltean
2023-09-12T00:58:22Z

On Sat, Sep 09, 2023 at 11:53:50AM +0300, Arınç ÜNAL wrote:
> What to do:
> - For mscc,vsc7514-switch, enforce phylink bindings for ports.
> - For mscc,vsc7512-switch, enforce phylink bindings for user ports.

you can also look at dsa_switches_apply_workarounds[], and if the switch
isn't there, then you can replace "user ports" with "ports" here and
everywhere.

> - renesas,rzn1-a5psw.yaml
> - renesas,r9a06g032-a5psw, renesas,rzn1-a5psw
>
> What to do:
> - Document "mdio".

Not clear here and for all the schemas quoted below.. is "mdio" not documented already?

> - realtek.yaml
> - realtek,rtl8365mb
> - realtek,rtl8366rb
>
> drivers/net/dsa/realtek/realtek-mdio.c:
> - The DSA subdriver lets the DSA driver register the bus.
>
> What to do:
> - Document "mdio".
> - Require "mdio". (Can't do because it's not required for MDIO controlled
> switches that share the compatible string with SMI controlled switches.
> This is why I would like Luiz to unify the bus registeration process.)
> - Document compatible string "realtek,smi-mdio" on "mdio" child node.
> - Require compatible. (Can't do because the same as above.)
> - Enforce phylink bindings for user ports. (Can't do because the same as
> above.)
> - Enforce phylink bindings for user ports if "mdio" is defined.
>
> ---
>
> - qca8k.yaml
> - qca,qca8327
> - qca,qca8328
> - qca,qca8334
> - qca,qca8337
>
> drivers/net/dsa/qca/qca8k-8xxx.c:
> - The DSA subdriver won't let the DSA driver register the bus.
> - No ds->ops->phy_read() or ds->ops->phy_write().
> - Registers the bus non-OF-based or OF-based. Registers OF-based if "mdio"
> child node is defined.
> - mdio = of_get_child_by_name(priv->dev->of_node, "mdio");
>
> What to do:
> - Document "mdio".
> - Enforce phylink bindings for user ports if "mdio" is defined.
>
> ---
>
> - nxp,sja1105.yaml
> - nxp,sja1105e
> - nxp,sja1105t
> - nxp,sja1105p
> - nxp,sja1105q
> - nxp,sja1105r
> - nxp,sja1105s
> - nxp,sja1110a
> - nxp,sja1110b
> - nxp,sja1110c
> - nxp,sja1110d
>
> What to do:
> - Document "mdios".
> - Document child node pattern property under "mdios".
> - Document "nxp,sja1110-base-tx-mdio" and "nxp,sja1110-base-t1-mdio"
> compatible strings.
> ---
>
> - microchip,lan937x.yaml
> - microchip,lan9370
> - microchip,lan9371
> - microchip,lan9372
> - microchip,lan9373
> - microchip,lan9374
> - microchip,ksz.yaml
> - microchip,ksz8765
> - microchip,ksz8794
> - microchip,ksz8795
> - microchip,ksz8863
> - microchip,ksz8873
> - microchip,ksz9477
> - microchip,ksz9897
> - microchip,ksz9896
> - microchip,ksz9567
> - microchip,ksz8565
> - microchip,ksz9893
> - microchip,ksz9563
> - microchip,ksz8563
>
> What to do:
> - Document "mdio".