Re: [PATCH 2/4] dt-bindings: net: dsa: document internal MDIO bus

Vladimir Oltean
2023-09-13T11:04:09Z

On Wed, Sep 13, 2023 at 01:59:17PM +0300, Arınç ÜNAL wrote:
> If I understand correctly, these phylink rules are for switch ports. The
> fixed-link, phy-handle, and managed properties are described on
> ethernet-controller.yaml so I thought it would make sense to define the
> rules there and refer to them where they're needed.
>
> Example:
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
> index 480120469953..7279ab31aea7 100644
> --- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
> @@ -65,16 +65,8 @@ if:
> - required: [ ethernet ]
> - required: [ link ]
> then:
> - allOf:
> - - required:
> - - phy-mode
> - - oneOf:
> - - required:
> - - fixed-link
> - - required:
> - - phy-handle
> - - required:
> - - managed
> + $ref: /schemas/net/ethernet-controller.yaml#/$defs/phylink-switch
> + required: [ phy-mode ]
> additionalProperties: true
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index e532c6b795f4..742aaf1a5ef2 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> @@ -179,6 +179,15 @@ required:
> - compatible
> - reg
> +if:
> + required: [ mdio ]
> +then:
> + patternProperties:
> + "^(ethernet-)?ports$":
> + patternProperties:
> + "^(ethernet-)?port@[0-9]+$":
> + $ref: /schemas/net/ethernet-controller.yaml#/$defs/phylink-switch
> +
> $defs:
> mt7530-dsa-port:
> patternProperties:
> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> index 9f6a5ccbcefe..d7256f33d946 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> @@ -284,6 +284,21 @@ allOf:
> controllers that have configurable TX internal delays. If this
> property is present then the MAC applies the TX delay.
> +$defs:
> + phylink-switch:
> + description: phylink bindings for switch ports
> + allOf:
> + - anyOf:
> + - required: [ fixed-link ]
> + - required: [ phy-handle ]
> + - required: [ managed ]
> +
> + - if:
> + required: [ fixed-link ]
> + then:
> + not:
> + required: [ managed ]
> +
> additionalProperties: true
> ...
>
> Arınç

I don't think they're for switch ports only. Any driver which uses
phylink_fwnode_phy_connect() or its derivatives gets subject to the same
bindings. But putting the sub-schema in ethernet-controller.yaml makes
sense, just maybe not naming it "phylink-switch".