From: Simon Horman <horms@kernel.org>
To: Pawel Chmielewski <pawel.chmielewski@intel.com>
Cc: intel-wired-lan@osuosl.org, netdev@vger.kernel.org,
andrew@lunn.ch, aelior@marvell.com, manishc@marvell.com,
Paul Greenwalt <paul.greenwalt@intel.com>
Subject: Re: [PATCH iwl-next v3 2/8] ethtool: Add forced speed to supported link modes maps
Date: Sun, 27 Aug 2023 18:59:17 +0200 [thread overview]
Message-ID: <20230827165917.GW3523530@kernel.org> (raw)
In-Reply-To: <20230823180633.2450617-3-pawel.chmielewski@intel.com>
On Wed, Aug 23, 2023 at 08:06:26PM +0200, Pawel Chmielewski wrote:
> From: Paul Greenwalt <paul.greenwalt@intel.com>
>
> The need to map Ethtool forced speeds to Ethtool supported link modes is
> common among drivers. To support this, add a common structure for forced
> speed maps and a function to init them. This is solution was originally
> introduced in commit 1d4e4ecccb11 ("qede: populate supported link modes
> maps on module init") for qede driver.
>
> ethtool_forced_speed_maps_init() should be called during driver init
> with an array of struct ethtool_forced_speed_map to populate the mapping.
>
> Definitions for maps themselves are left in the driver code, as the sets
> of supported link modes may vary betwen the devices.
Hi Pawel,
a minor nit from my side is that checkpatch.pl --codespell
suggests betwen -> between
>
> The qede driver was compile tested only.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
...
next prev parent reply other threads:[~2023-08-27 16:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 18:06 [PATCH iwl-next v3 0/8] ice: Add basic E830 support Pawel Chmielewski
2023-08-23 18:06 ` [PATCH iwl-next v3 1/8] ice: Add E830 device IDs, MAC type and registers Pawel Chmielewski
2023-08-23 18:06 ` [PATCH iwl-next v3 2/8] ethtool: Add forced speed to supported link modes maps Pawel Chmielewski
2023-08-25 22:21 ` [Intel-wired-lan] " kernel test robot
2023-08-27 16:59 ` Simon Horman [this message]
2023-08-23 18:06 ` [PATCH iwl-next v3 3/8] ice: Refactor finding advertised link speed Pawel Chmielewski
2023-08-23 18:06 ` [PATCH iwl-next v3 4/8] ice: Add 200G speed/phy type use Pawel Chmielewski
2023-08-23 18:06 ` [PATCH iwl-next v3 5/8] ice: Add ice_get_link_status_datalen Pawel Chmielewski
2023-08-23 18:06 ` [PATCH iwl-next v3 6/8] ice: Add support for E830 DDP package segment Pawel Chmielewski
2023-08-23 18:06 ` [PATCH iwl-next v3 7/8] ice: Remove redundant zeroing of the fields Pawel Chmielewski
2023-08-23 18:06 ` [PATCH iwl-next v3 8/8] ice: Hook up 4 E830 devices by adding their IDs Pawel Chmielewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230827165917.GW3523530@kernel.org \
--to=horms@kernel.org \
--cc=aelior@marvell.com \
--cc=andrew@lunn.ch \
--cc=intel-wired-lan@osuosl.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=paul.greenwalt@intel.com \
--cc=pawel.chmielewski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).