From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FCAF1802A for ; Tue, 29 Aug 2023 13:34:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24BC1C4339A; Tue, 29 Aug 2023 13:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693316053; bh=HC0YW4pjTa8Wf0Ln9pyi5PcI4UwgFrx0mp5RSj49dyQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lEdPesiQf/hNE5WwlGWtHToW0y6QPhZwv37kHO7nz6sTDn3NUv65NXCmghK2zKZXW ldxYEO99C+JNb8B0o0JXGz99YIq+eMAA+U8iylsmd1ainGkVWCEbDtI2cc89gcs4I0 dGpn2YXyWqLCpm5rQ9BpuO4+pRs3k2sd/MOwrkH+gH/tzWdruxTuLgvOVhsSpHEQEn JsFm43JyVL+ZdMwx/8nFjAY1B9qEZ5+OrqnKVKnhojzUKromUCukGigZAV/c7I/c6o E6PUFo5sgh4gsZaj6EMSUM00yLYleVDrGk64850O9040ujpM3Jsh41YoljOq8QK9LS a7cYn+0jgReiA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , "David S . Miller" , Sasha Levin , vyasevich@gmail.com, nhorman@tuxdriver.com, marcelo.leitner@gmail.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 3/5] sctp: handle invalid error codes without calling BUG() Date: Tue, 29 Aug 2023 09:34:04 -0400 Message-Id: <20230829133406.520756-3-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230829133406.520756-1-sashal@kernel.org> References: <20230829133406.520756-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.292 Content-Transfer-Encoding: 8bit From: Dan Carpenter [ Upstream commit a0067dfcd9418fd3b0632bc59210d120d038a9c6 ] The sctp_sf_eat_auth() function is supposed to return enum sctp_disposition values but if the call to sctp_ulpevent_make_authkey() fails, it returns -ENOMEM. This results in calling BUG() inside the sctp_side_effects() function. Calling BUG() is an over reaction and not helpful. Call WARN_ON_ONCE() instead. This code predates git. Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/sctp/sm_sideeffect.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c index 82d96441e64d6..c4a2d647e6cc7 100644 --- a/net/sctp/sm_sideeffect.c +++ b/net/sctp/sm_sideeffect.c @@ -1255,7 +1255,10 @@ static int sctp_side_effects(enum sctp_event event_type, default: pr_err("impossible disposition %d in state %d, event_type %d, event_id %d\n", status, state, event_type, subtype.chunk); - BUG(); + error = status; + if (error >= 0) + error = -EINVAL; + WARN_ON_ONCE(1); break; } -- 2.40.1