From: Oleksij Rempel <o.rempel@pengutronix.de>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Lukasz Majewski <lukma@denx.de>,
Eric Dumazet <edumazet@google.com>, Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, Woojung Huh <woojung.huh@microchip.com>,
Vladimir Oltean <olteanv@gmail.com>,
Tristram.Ha@microchip.com,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
UNGLinuxDriver@microchip.com,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C)
Date: Wed, 30 Aug 2023 16:48:31 +0200 [thread overview]
Message-ID: <20230830144831.GM31399@pengutronix.de> (raw)
In-Reply-To: <ZO9Uf5DjJ6Kf6uvh@shell.armlinux.org.uk>
On Wed, Aug 30, 2023 at 03:38:55PM +0100, Russell King (Oracle) wrote:
> On Wed, Aug 30, 2023 at 04:26:50PM +0200, Oleksij Rempel wrote:
> > @Lukasz,
> >
> > can you please try to set eee_broken_modes to all-ones. Somewhat like
> > this:
> > ksz9477_config_init()
> > ...
> > ...quirks...
> >
> > if (phydev->dev_flages & .. NO_EEE...)
> > phydev->eee_broken_modes = -1;
>
> That's fine in config_init().
>
> > err = genphy_restart_aneg(phydev);
>
> That isn't necessary, and in any case, calling it will just cause the
> AN enable and AN restart bits in BMCR to be set, nothing will be
> reprogrammed.
ack. It is already existing code, see:
https://elixir.bootlin.com/linux/v6.5/source/drivers/net/phy/micrel.c#L1822
Setting eee_broken_modes probably can be done at any plaice in this function.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-08-30 14:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 9:21 [PATCH 1/2] net: phy: Rename KSZ9477 get features function (to ksz9131_get_features) Lukasz Majewski
2023-08-30 9:21 ` [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C) Lukasz Majewski
2023-08-30 9:48 ` Michal Swiatkowski
2023-08-30 10:37 ` Lukasz Majewski
2023-08-30 10:18 ` Oleksij Rempel
2023-08-30 10:52 ` Lukasz Majewski
2023-08-30 10:59 ` Oleksij Rempel
2023-08-30 11:51 ` Lukasz Majewski
2023-08-30 12:17 ` Oleksij Rempel
2023-08-30 12:35 ` Russell King (Oracle)
2023-08-30 13:06 ` Oleksij Rempel
2023-08-30 13:30 ` Russell King (Oracle)
2023-08-30 14:26 ` Oleksij Rempel
2023-08-30 14:38 ` Russell King (Oracle)
2023-08-30 14:48 ` Oleksij Rempel [this message]
2023-08-30 16:38 ` Lukasz Majewski
2023-08-31 4:40 ` Oleksij Rempel
2023-08-31 7:13 ` Russell King (Oracle)
2023-08-30 13:23 ` Lukasz Majewski
2023-08-30 11:20 ` Russell King (Oracle)
2023-08-30 11:08 ` Russell King (Oracle)
2023-08-30 11:20 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830144831.GM31399@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).