[PATCH -next] ptp: ptp_ines: Use list_for_each_entry() helper

[PATCH -next] ptp: ptp_ines: Use list_for_each_entry() helper

[Jinjie Ruan]

Convert list_for_each() to list_for_each_entry() so that the this
list_head pointer and list_entry() call are no longer needed, which
can reduce a few lines of code. No functional changed.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 drivers/ptp/ptp_ines.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/ptp/ptp_ines.c b/drivers/ptp/ptp_ines.c
index ed215b458183..c74f2dbbe3a2 100644
--- a/drivers/ptp/ptp_ines.c
+++ b/drivers/ptp/ptp_ines.c
@@ -237,11 +237,9 @@ static struct ines_port *ines_find_port(struct device_node *node, u32 index)
 {
 	struct ines_port *port = NULL;
 	struct ines_clock *clock;
-	struct list_head *this;
 
 	mutex_lock(&ines_clocks_lock);
-	list_for_each(this, &ines_clocks) {
-		clock = list_entry(this, struct ines_clock, list);
+	list_for_each_entry(clock, &ines_clocks, list) {
 		if (clock->node == node) {
 			port = &clock->port[index];
 			break;
-- 
2.34.1

Re: [PATCH -next] ptp: ptp_ines: Use list_for_each_entry() helper

[Michal Swiatkowski]

On Wed, Aug 30, 2023 at 05:08:16PM +0800, Jinjie Ruan wrote:
> Convert list_for_each() to list_for_each_entry() so that the this
> list_head pointer and list_entry() call are no longer needed, which
> can reduce a few lines of code. No functional changed.
> 
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
>  drivers/ptp/ptp_ines.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_ines.c b/drivers/ptp/ptp_ines.c
> index ed215b458183..c74f2dbbe3a2 100644
> --- a/drivers/ptp/ptp_ines.c
> +++ b/drivers/ptp/ptp_ines.c
> @@ -237,11 +237,9 @@ static struct ines_port *ines_find_port(struct device_node *node, u32 index)
>  {
>  	struct ines_port *port = NULL;
>  	struct ines_clock *clock;
> -	struct list_head *this;
>  
>  	mutex_lock(&ines_clocks_lock);
> -	list_for_each(this, &ines_clocks) {
> -		clock = list_entry(this, struct ines_clock, list);
> +	list_for_each_entry(clock, &ines_clocks, list) {
>  		if (clock->node == node) {
>  			port = &clock->port[index];
>  			break;
> -- 
> 2.34.1
> 

Nice
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

Re: [PATCH -next] ptp: ptp_ines: Use list_for_each_entry() helper

[Jakub Kicinski]

On Wed, 30 Aug 2023 17:08:16 +0800 Jinjie Ruan wrote:
> Convert list_for_each() to list_for_each_entry() so that the this
> list_head pointer and list_entry() call are no longer needed, which
> can reduce a few lines of code. No functional changed.
> 
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>

## Form letter - net-next-closed

The merge window for v6.6 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after Sept 11th.

RFC patches sent for review only are obviously welcome at any time.

See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
-- 
pw-bot: defer