* Re: [PATCH] net/socket: Remove unnecessary ‘0’ values from used
2023-09-02 18:22 [PATCH] net/socket: Remove unnecessary ‘0’ values from used Li zeming
@ 2023-09-01 11:07 ` Denis Kirjanov
2023-09-02 0:57 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Denis Kirjanov @ 2023-09-01 11:07 UTC (permalink / raw)
To: Li zeming, davem, edumazet, kuba, pabeni; +Cc: netdev, linux-kernel
On 9/2/23 21:22, Li zeming wrote:
> used is assigned first, so it does not need to initialize the
> assignment.
that should be posted to net-next once it open
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> net/socket.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index 2b0e54b2405c..743e54eba06f 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -569,12 +569,12 @@ static ssize_t sockfs_listxattr(struct dentry *dentry, char *buffer,
> size_t size)
> {
> ssize_t len;
> - ssize_t used = 0;
> + ssize_t used;
>
> len = security_inode_listsecurity(d_inode(dentry), buffer, size);
> if (len < 0)
> return len;
> - used += len;
> + used = len;
> if (buffer) {
> if (size < used)
> return -ERANGE;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/socket: Remove unnecessary ‘0’ values from used
2023-09-02 18:22 [PATCH] net/socket: Remove unnecessary ‘0’ values from used Li zeming
2023-09-01 11:07 ` Denis Kirjanov
@ 2023-09-02 0:57 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-09-02 0:57 UTC (permalink / raw)
To: Li zeming; +Cc: davem, edumazet, pabeni, netdev, linux-kernel
On Sun, 3 Sep 2023 02:22:28 +0800 Li zeming wrote:
> used is assigned first, so it does not need to initialize the
> assignment.
It's a perfectly legitimate code pattern.
Please do not post any such patches to networking.
Please make sure you have read this:
https://docs.kernel.org/process/researcher-guidelines.html
--
pw-bot: reject
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] net/socket: Remove unnecessary ‘0’ values from used
@ 2023-09-02 18:22 Li zeming
2023-09-01 11:07 ` Denis Kirjanov
2023-09-02 0:57 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Li zeming @ 2023-09-02 18:22 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni; +Cc: netdev, linux-kernel, Li zeming
used is assigned first, so it does not need to initialize the
assignment.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
net/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index 2b0e54b2405c..743e54eba06f 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -569,12 +569,12 @@ static ssize_t sockfs_listxattr(struct dentry *dentry, char *buffer,
size_t size)
{
ssize_t len;
- ssize_t used = 0;
+ ssize_t used;
len = security_inode_listsecurity(d_inode(dentry), buffer, size);
if (len < 0)
return len;
- used += len;
+ used = len;
if (buffer) {
if (size < used)
return -ERANGE;
--
2.18.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-02 0:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-02 18:22 [PATCH] net/socket: Remove unnecessary ‘0’ values from used Li zeming
2023-09-01 11:07 ` Denis Kirjanov
2023-09-02 0:57 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).