Stable Backport: net: Avoid address overwrite in kernel_connect

Stable Backport: net: Avoid address overwrite in kernel_connect

[Jordan Rife]

Upstream Commit ID: 0bdf399342c5acbd817c9098b6c7ed21f1974312
Patchwork Link:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=0bdf399342c5
Requested Kernel Versions: 4.19, 5.4, 5.10, 5.15, 6.1, 6.4, 6.5

This patch addresses an incompatibility between eBPF connect4/connect6
programs and kernel space clients such as NFS. At present, the issue
this patch fixes is a blocker for users that want to combine NFS with
Cilium. The fix has been applied upstream but the same bug exists with
older kernels.

-Jordan

Re: Stable Backport: net: Avoid address overwrite in kernel_connect

[Daniel Borkmann]

[ Adding Greg to Cc ]

On 8/31/23 8:47 PM, Jordan Rife wrote:
> Upstream Commit ID: 0bdf399342c5acbd817c9098b6c7ed21f1974312
> Patchwork Link:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=0bdf399342c5
> Requested Kernel Versions: 4.19, 5.4, 5.10, 5.15, 6.1, 6.4, 6.5
> 
> This patch addresses an incompatibility between eBPF connect4/connect6
> programs and kernel space clients such as NFS. At present, the issue
> this patch fixes is a blocker for users that want to combine NFS with
> Cilium. The fix has been applied upstream but the same bug exists with
> older kernels.
> 
> -Jordan
> 

Re: Stable Backport: net: Avoid address overwrite in kernel_connect

[Greg KH]

On Thu, Aug 31, 2023 at 09:26:31PM +0200, Daniel Borkmann wrote:
> [ Adding Greg to Cc ]
> 
> On 8/31/23 8:47 PM, Jordan Rife wrote:
> > Upstream Commit ID: 0bdf399342c5acbd817c9098b6c7ed21f1974312
> > Patchwork Link:
> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=0bdf399342c5
> > Requested Kernel Versions: 4.19, 5.4, 5.10, 5.15, 6.1, 6.4, 6.5
> > 
> > This patch addresses an incompatibility between eBPF connect4/connect6
> > programs and kernel space clients such as NFS. At present, the issue
> > this patch fixes is a blocker for users that want to combine NFS with
> > Cilium. The fix has been applied upstream but the same bug exists with
> > older kernels.

Jordan:

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: Stable Backport: net: Avoid address overwrite in kernel_connect

[Jordan Rife]

Greg,

Sorry if I've misunderstood. The netdev FAQ
(https://www.kernel.org/doc/html/v5.7/networking/netdev-FAQ.html#q-i-see-a-network-patch-and-i-think-it-should-be-backported-to-stable)
seemed to indicate that I should send network backport requests to
netdev. I saw "option 2" in
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
which reads

> send an email to stable@vger.kernel.org containing the subject of the patch, the commit ID, why you think it should be applied, and what kernel version you wish it to be applied to.

Would "option 3" listed there be preferred?

-Jordan

On Thu, Aug 31, 2023 at 12:47 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Aug 31, 2023 at 09:26:31PM +0200, Daniel Borkmann wrote:
> > [ Adding Greg to Cc ]
> >
> > On 8/31/23 8:47 PM, Jordan Rife wrote:
> > > Upstream Commit ID: 0bdf399342c5acbd817c9098b6c7ed21f1974312
> > > Patchwork Link:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=0bdf399342c5
> > > Requested Kernel Versions: 4.19, 5.4, 5.10, 5.15, 6.1, 6.4, 6.5
> > >
> > > This patch addresses an incompatibility between eBPF connect4/connect6
> > > programs and kernel space clients such as NFS. At present, the issue
> > > this patch fixes is a blocker for users that want to combine NFS with
> > > Cilium. The fix has been applied upstream but the same bug exists with
> > > older kernels.
>
> Jordan:
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>

Re: Stable Backport: net: Avoid address overwrite in kernel_connect

[Greg KH]

On Thu, Aug 31, 2023 at 01:09:04PM -0700, Jordan Rife wrote:
> Greg,
> 
> Sorry if I've misunderstood. The netdev FAQ
> (https://www.kernel.org/doc/html/v5.7/networking/netdev-FAQ.html#q-i-see-a-network-patch-and-i-think-it-should-be-backported-to-stable)
> seemed to indicate that I should send network backport requests to
> netdev.

5.7 is a very old kernel version, please use the documentation from the
latest kernel version.

You can use "latest" instead of "v5.7" there.

> I saw "option 2" in
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> which reads
> 
> > send an email to stable@vger.kernel.org containing the subject of the patch, the commit ID, why you think it should be applied, and what kernel version you wish it to be applied to.
> 
> Would "option 3" listed there be preferred?

What's wrong with option 2?

thanks,

greg k-h

Re: Stable Backport: net: Avoid address overwrite in kernel_connect

[Jordan Rife]

Oops, my mistake. Sorry for the mixup! In that case, I will

> send an email to stable@vger.kernel.org containing the subject of the patch, the commit ID, why you think it should be applied, and what kernel version you wish it to be applied to.

as option 2 suggests.

-Jordan

On Thu, Aug 31, 2023 at 1:26 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Aug 31, 2023 at 01:09:04PM -0700, Jordan Rife wrote:
> > Greg,
> >
> > Sorry if I've misunderstood. The netdev FAQ
> > (https://www.kernel.org/doc/html/v5.7/networking/netdev-FAQ.html#q-i-see-a-network-patch-and-i-think-it-should-be-backported-to-stable)
> > seemed to indicate that I should send network backport requests to
> > netdev.
>
> 5.7 is a very old kernel version, please use the documentation from the
> latest kernel version.
>
> You can use "latest" instead of "v5.7" there.
>
> > I saw "option 2" in
> > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > which reads
> >
> > > send an email to stable@vger.kernel.org containing the subject of the patch, the commit ID, why you think it should be applied, and what kernel version you wish it to be applied to.
> >
> > Would "option 3" listed there be preferred?
>
> What's wrong with option 2?
>
> thanks,
>
> greg k-h

Re: Stable Backport: net: Avoid address overwrite in kernel_connect

[Greg KH]

On Thu, Aug 31, 2023 at 09:26:31PM +0200, Daniel Borkmann wrote:
> [ Adding Greg to Cc ]
> 
> On 8/31/23 8:47 PM, Jordan Rife wrote:
> > Upstream Commit ID: 0bdf399342c5acbd817c9098b6c7ed21f1974312
> > Patchwork Link:
> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=0bdf399342c5
> > Requested Kernel Versions: 4.19, 5.4, 5.10, 5.15, 6.1, 6.4, 6.5
> > 
> > This patch addresses an incompatibility between eBPF connect4/connect6
> > programs and kernel space clients such as NFS. At present, the issue
> > this patch fixes is a blocker for users that want to combine NFS with
> > Cilium. The fix has been applied upstream but the same bug exists with
> > older kernels.

Also, no one tested this, it doesn't even actually apply to any of those
trees :(

Jordan, please provide working backports after you have tested this, if
you wish to see it applied to any stable trees.

thanks,

greg k-h