From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Lukasz Majewski <lukma@denx.de>
Cc: Tristram.Ha@microchip.com, Eric Dumazet <edumazet@google.com>,
davem@davemloft.net, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kristian Overskeid <koverskeid@gmail.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Oetken <ennoerlangen@gmail.com>
Subject: Re: [PATCH] net: hsr : Provide fix for HSRv1 supervisor frames decoding
Date: Tue, 5 Sep 2023 10:06:14 +0200 [thread overview]
Message-ID: <20230905080614.ImjTS6iw@linutronix.de> (raw)
In-Reply-To: <20230825153111.228768-1-lukma@denx.de>
On 2023-08-25 17:31:11 [+0200], Lukasz Majewski wrote:
> Provide fix to decode correctly supervisory frames when HSRv1 version of
> the HSR protocol is used.
>
> Without this patch console is polluted with:
> ksz-switch spi1.0 lan1: hsr_addr_subst_dest: Unknown node
>
> as a result of destination node's A MAC address equals to:
> 00:00:00:00:00:00.
>
> cat /sys/kernel/debug/hsr/hsr0/node_table
> Node Table entries for (HSR) device
> MAC-Address-A, MAC-Address-B, time_in[A], time_in[B], Address-B
> 00:00:00:00:00:00 00:10:a1:94:77:30 400bf, 399c, 0
>
> It was caused by wrong frames decoding in the hsr_handle_sup_frame().
>
> As the supervisor frame is encapsulated in HSRv1 frame:
>
> SKB_I100000000: 01 15 4e 00 01 2d 00 10 a1 94 77 30 89 2f 00 34
> SKB_I100000010: 02 59 88 fb 00 01 84 15 17 06 00 10 a1 94 77 30
> SKB_I100000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> SKB_I100000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> SKB_I100000040: 00 00
>
> The code had to be adjusted accordingly and the MAC-Address-A now
> has the proper address (the MAC-Address-B now has all 0's).
Was this broken by commit
eafaa88b3eb7f ("net: hsr: Add support for redbox supervision frames")
? Is this frame somehow special? I don't remember this…
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Sebastian
next prev parent reply other threads:[~2023-09-05 8:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 15:31 [PATCH] net: hsr : Provide fix for HSRv1 supervisor frames decoding Lukasz Majewski
2023-08-25 18:10 ` Tristram.Ha
2023-08-28 9:02 ` Lukasz Majewski
2023-08-31 13:38 ` Lukasz Majewski
2023-09-04 15:54 ` Lukasz Majewski
2023-08-25 23:44 ` kernel test robot
2023-08-26 0:38 ` kernel test robot
2023-09-05 8:06 ` Sebastian Andrzej Siewior [this message]
2023-09-05 9:55 ` Lukasz Majewski
2023-09-11 14:57 ` Lukasz Majewski
2023-09-11 15:01 ` Sebastian Andrzej Siewior
2023-09-12 8:18 ` Lukasz Majewski
2023-09-13 16:32 ` Sebastian Andrzej Siewior
2023-09-14 12:26 ` Lukasz Majewski
2023-09-14 12:32 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905080614.ImjTS6iw@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Tristram.Ha@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ennoerlangen@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=koverskeid@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).