From: Jakub Kicinski <kuba@kernel.org>
To: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>
Cc: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Neftin, Sasha" <sasha.neftin@intel.com>,
"horms@kernel.org" <horms@kernel.org>,
"bcreeley@amd.com" <bcreeley@amd.com>,
Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net v3 2/2] igc: Modify the tx-usecs coalesce setting
Date: Wed, 6 Sep 2023 07:46:32 -0700 [thread overview]
Message-ID: <20230906074632.0fc246e9@kernel.org> (raw)
In-Reply-To: <SJ1PR11MB6180C190E2ADF4FB2B17A430B8EFA@SJ1PR11MB6180.namprd11.prod.outlook.com>
On Wed, 6 Sep 2023 02:52:30 +0000 Zulkifli, Muhammad Husaini wrote:
> > In the ioctl uAPI we can't differentiate between params which were echoed back
> > to us vs those user set via CLI to what they already were.
> >
> > Maybe we should extend the uAPI and add a "queue pair" IRQ moderation?
>
> Good advice. BTW, if queue pair setting is enabled in the driver, could we change the existing ".supported_coalesce_params" for driver specific?
>
> From:
> ETHTOOL_COALESCE_USECS which support (ETHTOOL_COALESCE_RX_USECS | ETHTOOL_COALESCE_TX_USECS)
>
> To (new define):
> ETHTOOL_QUEUE_PAIR_COALESCE_USECS (ETHTOOL_COALESCE_RX_USECS)
>
> With this, I believe user cannot set tx-usecs and will return error of unsupported parameters.
Do you mean change the .supported_coalesce_params at runtime?
I think so far we were expecting drivers to set flags for all types
they may support and then reject the settings incompatible with current
operation mode at the driver level.
next prev parent reply other threads:[~2023-09-06 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 22:16 [PATCH net v3 0/2][pull request] igc: Enhance the tx-usecs coalesce setting implementation Tony Nguyen
2023-08-22 22:16 ` [PATCH net v3 1/2] igc: Expose tx-usecs coalesce setting to user Tony Nguyen
2023-08-22 22:16 ` [PATCH net v3 2/2] igc: Modify the tx-usecs coalesce setting Tony Nguyen
2023-08-24 2:19 ` Jakub Kicinski
2023-08-24 22:50 ` Zulkifli, Muhammad Husaini
2023-08-25 0:00 ` Jakub Kicinski
2023-08-25 3:44 ` Zulkifli, Muhammad Husaini
2023-08-26 0:34 ` Jakub Kicinski
2023-09-04 0:59 ` Zulkifli, Muhammad Husaini
2023-09-05 17:15 ` Jakub Kicinski
2023-09-06 2:52 ` Zulkifli, Muhammad Husaini
2023-09-06 14:46 ` Jakub Kicinski [this message]
2023-09-06 15:02 ` Zulkifli, Muhammad Husaini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906074632.0fc246e9@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=bcreeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).