From: Stephen Hemminger <stephen@networkplumber.org>
To: Yuchung Cheng <ycheng@google.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Soheil Hassas Yeganeh <soheil@google.com>,
Neal Cardwell <ncardwell@google.com>
Subject: Re: [RFC net-next 4/4] tcp: defer regular ACK while processing socket backlog
Date: Wed, 6 Sep 2023 16:07:29 -0700 [thread overview]
Message-ID: <20230906160729.3cf829c0@hermes.local> (raw)
In-Reply-To: <CAK6E8=enK954aGeq0Rq8WDBJM8Rdp90_O=Rt_ax8bUHfStunOg@mail.gmail.com>
On Wed, 6 Sep 2023 13:31:17 -0700
Yuchung Cheng <ycheng@google.com> wrote:
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
>
> Looks great. Any reason any workload may want to switch this feature
> off? I can't think of one...
Never underestimate the likelihood that some TCP stack or middlebox
is broken and needs more ACK's to work.
next prev parent reply other threads:[~2023-09-06 23:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 20:10 [RFC net-next 0/4] tcp: backlog processing optims Eric Dumazet
2023-09-06 20:10 ` [RFC net-next 1/4] tcp: no longer release socket ownership in tcp_release_cb() Eric Dumazet
2023-09-06 20:10 ` [RFC net-next 2/4] net: sock_release_ownership() cleanup Eric Dumazet
2023-09-06 20:10 ` [RFC net-next 3/4] net: call prot->release_cb() when processing backlog Eric Dumazet
2023-09-06 20:10 ` [RFC net-next 4/4] tcp: defer regular ACK while processing socket backlog Eric Dumazet
2023-09-06 20:31 ` Yuchung Cheng
2023-09-06 23:07 ` Stephen Hemminger [this message]
2023-09-07 14:07 ` Neal Cardwell
2023-09-07 14:35 ` Soheil Hassas Yeganeh
[not found] ` <CAA93jw7Fuov-vmxiZdW7My-AVWCOFQo4XVm9bNwAg4Td2CUNCA@mail.gmail.com>
2023-09-07 16:54 ` Eric Dumazet
2023-09-07 17:09 ` Jakub Kicinski
2023-09-07 17:16 ` Eric Dumazet
2023-09-07 18:00 ` Jakub Kicinski
2023-09-07 18:05 ` Eric Dumazet
2023-09-07 18:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906160729.3cf829c0@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).