From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BC2F11CB5 for ; Wed, 6 Sep 2023 23:07:33 +0000 (UTC) Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 659531BC5 for ; Wed, 6 Sep 2023 16:07:31 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1c35ee3b0d2so2639645ad.2 for ; Wed, 06 Sep 2023 16:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1694041651; x=1694646451; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2BB+Hxdtx5DADV02vPh1iR2xptyEn/ejXtG+GUfzw7I=; b=CtbJVQfAKbxouDKkZp+XrMw8D0yYXRBQOwaDpYdQqmDAz8rvbPiCuaCR2bwcQtwNWE oouktPrD0B7LR2Yfk0wyvjsqqQAVHqEGyMlpKA/EWtYaSnb+2qXZ4j8e1XZA5D4RG7Wx WaTC3pECBcg/gwETje1WMA/a0WjvRduYkw50aWk0cfrwsFbjZGjMrQvpSxHOXcZHz7l3 BPFy2lObye78lQRhi9fIPKZCYd4riBjihShrXMhZXGxX2W4kMOgU5UksrWKDgbhydz7o cCtYrI/tCPRqWuDAzQQ2xe0YLaJLG/X5B+f2OVgCkxA38WRBEA3hZLCCcf3qFhn29reF 3l6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694041651; x=1694646451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2BB+Hxdtx5DADV02vPh1iR2xptyEn/ejXtG+GUfzw7I=; b=X7DP8jOsipdWzkucKEpuEj6m+lLLRXQp0EYfIeaCZsvc/MoyOMVdxm6b2OAt/1t9ek IzTfj1+VLKN2dvvCL1v1PXQocAJa6hzaesecw5/ZAuov/mx6URdCzNTz6P5LbT87PQvZ 0Qkf4fhqMbpFn+yLQpirLkobbyijn3DQ7iNx0nrHiwzoc+vTPupiLqn03KGdPpDTz3jJ epOD8HxrxQur0CzAWRwqtZibcVxTlm5aJEOhvgrY4tPsEjqPIgViBHrYfwQqxEvGFt1B LezgRwzYnlmGD19WDTVbTApS+InnGFwnclYvI0Cpk+FhmfDB2Ihv0OmN/Nzl/wfecHqd Mj/g== X-Gm-Message-State: AOJu0Yz7nacAKB3qgeK27Qf/mMo7Wtv3X/URIMOrHpWrF6InrPYlPFq4 x0dYlXzwWEBAYCb4XwXgPqvylw== X-Google-Smtp-Source: AGHT+IFKFy6QKaFs5Ky4izQr1Dm8yFJD4LHtH6e8e/V6LN0iG/HMkKD8N9tS5imvR+K5g8y1gQ68Pg== X-Received: by 2002:a17:902:efd4:b0:1c0:db5a:8c78 with SMTP id ja20-20020a170902efd400b001c0db5a8c78mr13051140plb.68.1694041650900; Wed, 06 Sep 2023 16:07:30 -0700 (PDT) Received: from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131]) by smtp.gmail.com with ESMTPSA id x2-20020a170902ea8200b001bc2831e1a9sm11490868plb.90.2023.09.06.16.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 16:07:30 -0700 (PDT) Date: Wed, 6 Sep 2023 16:07:29 -0700 From: Stephen Hemminger To: Yuchung Cheng Cc: Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, eric.dumazet@gmail.com, Soheil Hassas Yeganeh , Neal Cardwell Subject: Re: [RFC net-next 4/4] tcp: defer regular ACK while processing socket backlog Message-ID: <20230906160729.3cf829c0@hermes.local> In-Reply-To: References: <20230906201046.463236-1-edumazet@google.com> <20230906201046.463236-5-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, 6 Sep 2023 13:31:17 -0700 Yuchung Cheng wrote: > > > > Signed-off-by: Eric Dumazet > Signed-off-by: Yuchung Cheng > > Looks great. Any reason any workload may want to switch this feature > off? I can't think of one... Never underestimate the likelihood that some TCP stack or middlebox is broken and needs more ACK's to work.