From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"hawk@kernel.org" <hawk@kernel.org>,
"alexander.duyck@gmail.com" <alexander.duyck@gmail.com>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
"linyunsheng@huawei.com" <linyunsheng@huawei.com>
Subject: Re: RE: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool cache index corruption.
Date: Thu, 7 Sep 2023 12:15:27 +0200 [thread overview]
Message-ID: <20230907101527.45YwOJcG@linutronix.de> (raw)
In-Reply-To: <MWHPR1801MB19187A03AF45B0E23B534B6BD3EEA@MWHPR1801MB1918.namprd18.prod.outlook.com>
On 2023-09-07 08:15:58 [+0000], Ratheesh Kannoth wrote:
> > From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > Subject: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool cache index
> > corruption.
> > > cq->refill_task_sched = false;
> > > +
> > > + local_bh_disable();
> > > + napi_schedule(wrk->napi);
> > > + local_bh_enable();
> >
> > This is a nitpick since I haven't look how it works exactly: Is it possible that the
> > wrk->napi pointer gets overwritten by
> > otx2_napi_handler() since you cleared cq->refill_task_sched() earlier?
> I don’t see any issue here. As NAPI and workqueue execution is serialized (as interrupt is disabled when
> Workqueue is scheduled). I don’t think we can move "refill_task_sched = false" after local_bh_enable().
> But we can move refill_task_sched = false as below . but I don’t see a need.
Right, there might be no issue I was just asking. I don't know how the
cq <-> NAPI mapping is working. If you say that there is no race/issue,
okay ;)
> +
> + local_bh_disable();
> + napi_schedule(wrk->napi);
> + cq->refill_task_sched = false;
> + local_bh_enable();
Sebastian
next prev parent reply other threads:[~2023-09-07 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 1:47 [PATCH net v2] octeontx2-pf: Fix page pool cache index corruption Ratheesh Kannoth
2023-09-07 7:09 ` Sebastian Andrzej Siewior
2023-09-07 8:15 ` [EXT] " Ratheesh Kannoth
2023-09-07 10:15 ` Sebastian Andrzej Siewior [this message]
2023-09-07 15:08 ` Simon Horman
2023-09-08 2:51 ` [EXT] " Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907101527.45YwOJcG@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hawk@kernel.org \
--cc=hkelam@marvell.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).