* [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper
@ 2023-09-07 15:02 Petr Oros
2023-09-07 15:02 ` [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan Petr Oros
2023-09-07 15:31 ` [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper Simon Horman
0 siblings, 2 replies; 7+ messages in thread
From: Petr Oros @ 2023-09-07 15:02 UTC (permalink / raw)
To: netdev
Cc: jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba, pabeni,
intel-wired-lan, linux-kernel, mschmidt, ivecera, ahmed.zaki,
horms
Add helper for set iavf aq request AVF_FLAG_AQ_* and immediately
schedule watchdog_task. Helper will be used in cases where it is
necessary to run aq requests asap
Signed-off-by: Petr Oros <poros@redhat.com>
Co-developed-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Co-developed-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/net/ethernet/intel/iavf/iavf.h | 2 +-
drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 2 +-
drivers/net/ethernet/intel/iavf/iavf_main.c | 10 ++++------
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h
index 85fba85fbb232b..e110ba3461857b 100644
--- a/drivers/net/ethernet/intel/iavf/iavf.h
+++ b/drivers/net/ethernet/intel/iavf/iavf.h
@@ -521,7 +521,7 @@ void iavf_down(struct iavf_adapter *adapter);
int iavf_process_config(struct iavf_adapter *adapter);
int iavf_parse_vf_resource_msg(struct iavf_adapter *adapter);
void iavf_schedule_reset(struct iavf_adapter *adapter, u64 flags);
-void iavf_schedule_request_stats(struct iavf_adapter *adapter);
+void iavf_schedule_aq_request(struct iavf_adapter *adapter, u64 flags);
void iavf_schedule_finish_config(struct iavf_adapter *adapter);
void iavf_reset(struct iavf_adapter *adapter);
void iavf_set_ethtool_ops(struct net_device *netdev);
diff --git a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
index a34303ad057d00..90397293525f71 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
@@ -362,7 +362,7 @@ static void iavf_get_ethtool_stats(struct net_device *netdev,
unsigned int i;
/* Explicitly request stats refresh */
- iavf_schedule_request_stats(adapter);
+ iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_REQUEST_STATS);
iavf_add_ethtool_stats(&data, adapter, iavf_gstrings_stats);
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 7b300c86ceda73..86d472dfdbc10c 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -314,15 +314,13 @@ void iavf_schedule_reset(struct iavf_adapter *adapter, u64 flags)
}
/**
- * iavf_schedule_request_stats - Set the flags and schedule statistics request
+ * iavf_schedule_aq_request - Set the flags and schedule aq request
* @adapter: board private structure
- *
- * Sets IAVF_FLAG_AQ_REQUEST_STATS flag so iavf_watchdog_task() will explicitly
- * request and refresh ethtool stats
+ * @flags: requested aq flags
**/
-void iavf_schedule_request_stats(struct iavf_adapter *adapter)
+void iavf_schedule_aq_request(struct iavf_adapter *adapter, u64 flags)
{
- adapter->aq_required |= IAVF_FLAG_AQ_REQUEST_STATS;
+ adapter->aq_required |= flags;
mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0);
}
--
2.42.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan
2023-09-07 15:02 [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper Petr Oros
@ 2023-09-07 15:02 ` Petr Oros
2023-09-07 15:31 ` Simon Horman
2023-09-08 20:10 ` Tony Nguyen
2023-09-07 15:31 ` [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper Simon Horman
1 sibling, 2 replies; 7+ messages in thread
From: Petr Oros @ 2023-09-07 15:02 UTC (permalink / raw)
To: netdev
Cc: jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba, pabeni,
intel-wired-lan, linux-kernel, mschmidt, ivecera, ahmed.zaki,
horms
When the iavf driver wants to reconfigure the VLAN filters
(iavf_add_vlan, iavf_del_vlan), it sets a flag in
aq_required:
adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
or:
adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
This is later processed by the watchdog_task, but it runs periodically
every 2 seconds, so it can be a long time before it processes the request.
In the worst case, the interface is unable to receive traffic for more
than 2 seconds for no objective reason.
Signed-off-by: Petr Oros <poros@redhat.com>
Co-developed-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Co-developed-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 86d472dfdbc10c..d9f8ac1d57fd62 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter,
list_add_tail(&f->list, &adapter->vlan_filter_list);
f->state = IAVF_VLAN_ADD;
adapter->num_vlan_filters++;
- adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
+ iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER);
}
clearout:
@@ -843,7 +843,7 @@ static void iavf_del_vlan(struct iavf_adapter *adapter, struct iavf_vlan vlan)
f = iavf_find_vlan(adapter, vlan);
if (f) {
f->state = IAVF_VLAN_REMOVE;
- adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
+ iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_DEL_VLAN_FILTER);
}
spin_unlock_bh(&adapter->mac_vlan_list_lock);
--
2.42.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan
2023-09-07 15:02 ` [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan Petr Oros
@ 2023-09-07 15:31 ` Simon Horman
2023-09-08 20:10 ` Tony Nguyen
1 sibling, 0 replies; 7+ messages in thread
From: Simon Horman @ 2023-09-07 15:31 UTC (permalink / raw)
To: Petr Oros
Cc: netdev, jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba,
pabeni, intel-wired-lan, linux-kernel, mschmidt, ivecera,
ahmed.zaki
On Thu, Sep 07, 2023 at 05:02:51PM +0200, Petr Oros wrote:
> When the iavf driver wants to reconfigure the VLAN filters
> (iavf_add_vlan, iavf_del_vlan), it sets a flag in
> aq_required:
> adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> or:
> adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
>
> This is later processed by the watchdog_task, but it runs periodically
> every 2 seconds, so it can be a long time before it processes the request.
>
> In the worst case, the interface is unable to receive traffic for more
> than 2 seconds for no objective reason.
>
> Signed-off-by: Petr Oros <poros@redhat.com>
> Co-developed-by: Michal Schmidt <mschmidt@redhat.com>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> Co-developed-by: Ivan Vecera <ivecera@redhat.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan
2023-09-07 15:02 ` [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan Petr Oros
2023-09-07 15:31 ` Simon Horman
@ 2023-09-08 20:10 ` Tony Nguyen
2023-09-15 8:40 ` [Intel-wired-lan] " Romanowski, Rafal
1 sibling, 1 reply; 7+ messages in thread
From: Tony Nguyen @ 2023-09-08 20:10 UTC (permalink / raw)
To: Petr Oros, netdev
Cc: jesse.brandeburg, davem, edumazet, kuba, pabeni, intel-wired-lan,
linux-kernel, mschmidt, ivecera, ahmed.zaki, horms
On 9/7/2023 8:02 AM, Petr Oros wrote:
> When the iavf driver wants to reconfigure the VLAN filters
> (iavf_add_vlan, iavf_del_vlan), it sets a flag in
> aq_required:
> adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> or:
> adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
>
> This is later processed by the watchdog_task, but it runs periodically
> every 2 seconds, so it can be a long time before it processes the request.
>
> In the worst case, the interface is unable to receive traffic for more
> than 2 seconds for no objective reason.
>
Changes look ok, however, can you supply or add a Fixes:?
> Signed-off-by: Petr Oros <poros@redhat.com>
> Co-developed-by: Michal Schmidt <mschmidt@redhat.com>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> Co-developed-by: Ivan Vecera <ivecera@redhat.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 86d472dfdbc10c..d9f8ac1d57fd62 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter,
> list_add_tail(&f->list, &adapter->vlan_filter_list);
> f->state = IAVF_VLAN_ADD;
> adapter->num_vlan_filters++;
> - adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> + iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER);
> }
>
> clearout:
> @@ -843,7 +843,7 @@ static void iavf_del_vlan(struct iavf_adapter *adapter, struct iavf_vlan vlan)
> f = iavf_find_vlan(adapter, vlan);
> if (f) {
> f->state = IAVF_VLAN_REMOVE;
> - adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
> + iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_DEL_VLAN_FILTER);
> }
>
> spin_unlock_bh(&adapter->mac_vlan_list_lock);
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan
2023-09-08 20:10 ` Tony Nguyen
@ 2023-09-15 8:40 ` Romanowski, Rafal
0 siblings, 0 replies; 7+ messages in thread
From: Romanowski, Rafal @ 2023-09-15 8:40 UTC (permalink / raw)
To: Nguyen, Anthony L, poros, netdev@vger.kernel.org
Cc: ivecera, Brandeburg, Jesse, linux-kernel@vger.kernel.org,
edumazet@google.com, intel-wired-lan@lists.osuosl.org,
horms@kernel.org, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Friday, September 8, 2023 10:11 PM
> To: poros <poros@redhat.com>; netdev@vger.kernel.org
> Cc: ivecera <ivecera@redhat.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; linux-kernel@vger.kernel.org;
> edumazet@google.com; intel-wired-lan@lists.osuosl.org; horms@kernel.org;
> kuba@kernel.org; pabeni@redhat.com; davem@davemloft.net
> Subject: Re: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request
> immediately after add/delete vlan
>
>
>
> On 9/7/2023 8:02 AM, Petr Oros wrote:
> > When the iavf driver wants to reconfigure the VLAN filters
> > (iavf_add_vlan, iavf_del_vlan), it sets a flag in
> > aq_required:
> > adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> > or:
> > adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
> >
> > This is later processed by the watchdog_task, but it runs periodically
> > every 2 seconds, so it can be a long time before it processes the request.
> >
> > In the worst case, the interface is unable to receive traffic for more
> > than 2 seconds for no objective reason.
> >
>
> Changes look ok, however, can you supply or add a Fixes:?
>
> > Signed-off-by: Petr Oros <poros@redhat.com>
> > Co-developed-by: Michal Schmidt <mschmidt@redhat.com>
> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> > Co-developed-by: Ivan Vecera <ivecera@redhat.com>
> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> > Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com>
> > ---
> > drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > index 86d472dfdbc10c..d9f8ac1d57fd62 100644
> > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > @@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper
2023-09-07 15:02 [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper Petr Oros
2023-09-07 15:02 ` [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan Petr Oros
@ 2023-09-07 15:31 ` Simon Horman
2023-09-15 8:39 ` [Intel-wired-lan] " Romanowski, Rafal
1 sibling, 1 reply; 7+ messages in thread
From: Simon Horman @ 2023-09-07 15:31 UTC (permalink / raw)
To: Petr Oros
Cc: netdev, jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba,
pabeni, intel-wired-lan, linux-kernel, mschmidt, ivecera,
ahmed.zaki
On Thu, Sep 07, 2023 at 05:02:50PM +0200, Petr Oros wrote:
> Add helper for set iavf aq request AVF_FLAG_AQ_* and immediately
> schedule watchdog_task. Helper will be used in cases where it is
> necessary to run aq requests asap
>
> Signed-off-by: Petr Oros <poros@redhat.com>
> Co-developed-by: Michal Schmidt <mschmidt@redhat.com>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> Co-developed-by: Ivan Vecera <ivecera@redhat.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [Intel-wired-lan] [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper
2023-09-07 15:31 ` [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper Simon Horman
@ 2023-09-15 8:39 ` Romanowski, Rafal
0 siblings, 0 replies; 7+ messages in thread
From: Romanowski, Rafal @ 2023-09-15 8:39 UTC (permalink / raw)
To: Simon Horman, poros
Cc: ivecera, netdev@vger.kernel.org, Brandeburg, Jesse,
linux-kernel@vger.kernel.org, edumazet@google.com,
Nguyen, Anthony L, intel-wired-lan@lists.osuosl.org,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Simon Horman
> Sent: Thursday, September 7, 2023 5:31 PM
> To: poros <poros@redhat.com>
> Cc: ivecera <ivecera@redhat.com>; netdev@vger.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@intel.com>; linux-kernel@vger.kernel.org;
> edumazet@google.com; Nguyen, Anthony L <anthony.l.nguyen@intel.com>;
> intel-wired-lan@lists.osuosl.org; kuba@kernel.org; pabeni@redhat.com;
> davem@davemloft.net
> Subject: Re: [Intel-wired-lan] [PATCH net v2 1/2] iavf: add
> iavf_schedule_aq_request() helper
>
> On Thu, Sep 07, 2023 at 05:02:50PM +0200, Petr Oros wrote:
> > Add helper for set iavf aq request AVF_FLAG_AQ_* and immediately
> > schedule watchdog_task. Helper will be used in cases where it is
> > necessary to run aq requests asap
> >
> > Signed-off-by: Petr Oros <poros@redhat.com>
> > Co-developed-by: Michal Schmidt <mschmidt@redhat.com>
> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> > Co-developed-by: Ivan Vecera <ivecera@redhat.com>
> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-09-15 8:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-07 15:02 [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper Petr Oros
2023-09-07 15:02 ` [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan Petr Oros
2023-09-07 15:31 ` Simon Horman
2023-09-08 20:10 ` Tony Nguyen
2023-09-15 8:40 ` [Intel-wired-lan] " Romanowski, Rafal
2023-09-07 15:31 ` [PATCH net v2 1/2] iavf: add iavf_schedule_aq_request() helper Simon Horman
2023-09-15 8:39 ` [Intel-wired-lan] " Romanowski, Rafal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).