From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE0BD14AAF for ; Fri, 8 Sep 2023 18:20:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E8DDC43397; Fri, 8 Sep 2023 18:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694197235; bh=hD5njIcyf2lCixVvKUZXY/u9nTKEI62ubS16D3oz5Vc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qn0wzgJx+ySTpY2Cz/camjcoKJCspGqcAPEVA3Ys2WTGEO/umhcFXNg3fC0m+v4xM jOcb74DVNU/OTNc/qxLFQw7oG85/GpW9exF0wHaUG/9ppntmveI5mn4A+VUknIqyv0 X3EC2dYI3oiIisZv5mEHvK/XgNXqu8u7lReY2O/6cZLjLrA2WVqs3DSk85vLPxoQUe Ow0ab6JUP3RD6XHKK4g8neAbufj08yXCwSEC9iBVnprkI2UgzVleAc9sqraj7v6gh5 Y9lchzpPnzqjzFzXtjQfWsg/ARBDaNgK40+IPx9MhsSUHZnxqV1flVnQTwVnLvYDKg vF4r4XCQvWa6Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "GONG, Ruiqi" , GONG, Simon Horman , Paolo Abeni , Sasha Levin , chris.snook@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 10/14] alx: fix OOB-read compiler warning Date: Fri, 8 Sep 2023 14:19:57 -0400 Message-Id: <20230908182003.3460721-10-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230908182003.3460721-1-sashal@kernel.org> References: <20230908182003.3460721-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.194 Content-Transfer-Encoding: 8bit From: "GONG, Ruiqi" [ Upstream commit 3a198c95c95da10ad844cbeade2fe40bdf14c411 ] The following message shows up when compiling with W=1: In function ‘fortify_memcpy_chk’, inlined from ‘alx_get_ethtool_stats’ at drivers/net/ethernet/atheros/alx/ethtool.c:297:2: ./include/linux/fortify-string.h:592:4: error: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of field (2nd parameter); maybe use struct_group()? [-Werror=attribute-warning] 592 | __read_overflow2_field(q_size_field, size); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In order to get alx stats altogether, alx_get_ethtool_stats() reads beyond hw->stats.rx_ok. Fix this warning by directly copying hw->stats, and refactor the unnecessarily complicated BUILD_BUG_ON btw. Signed-off-by: GONG, Ruiqi Reviewed-by: Simon Horman Link: https://lore.kernel.org/r/20230821013218.1614265-1-gongruiqi@huaweicloud.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/atheros/alx/ethtool.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/atheros/alx/ethtool.c b/drivers/net/ethernet/atheros/alx/ethtool.c index 2f4eabf652e80..51e5aa2c74b34 100644 --- a/drivers/net/ethernet/atheros/alx/ethtool.c +++ b/drivers/net/ethernet/atheros/alx/ethtool.c @@ -281,9 +281,8 @@ static void alx_get_ethtool_stats(struct net_device *netdev, spin_lock(&alx->stats_lock); alx_update_hw_stats(hw); - BUILD_BUG_ON(sizeof(hw->stats) - offsetof(struct alx_hw_stats, rx_ok) < - ALX_NUM_STATS * sizeof(u64)); - memcpy(data, &hw->stats.rx_ok, ALX_NUM_STATS * sizeof(u64)); + BUILD_BUG_ON(sizeof(hw->stats) != ALX_NUM_STATS * sizeof(u64)); + memcpy(data, &hw->stats, sizeof(hw->stats)); spin_unlock(&alx->stats_lock); } -- 2.40.1