From: kernel test robot <lkp@intel.com>
To: Stanislav Fomichev <sdf@google.com>, bpf@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, netdev@vger.kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH bpf-next 2/3] bpf: expose information about supported xdp metadata kfunc
Date: Sat, 9 Sep 2023 19:23:14 +0800 [thread overview]
Message-ID: <202309091923.UTfYFF4J-lkp@intel.com> (raw)
In-Reply-To: <20230908225807.1780455-3-sdf@google.com>
Hi Stanislav,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/bpf-make-it-easier-to-add-new-metadata-kfunc/20230909-070017
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20230908225807.1780455-3-sdf%40google.com
patch subject: [PATCH bpf-next 2/3] bpf: expose information about supported xdp metadata kfunc
config: i386-randconfig-141-20230909 (https://download.01.org/0day-ci/archive/20230909/202309091923.UTfYFF4J-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230909/202309091923.UTfYFF4J-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309091923.UTfYFF4J-lkp@intel.com/
smatch warnings:
net/core/netdev-genl.c:26 netdev_nl_dev_fill() warn: inconsistent indenting
vim +26 net/core/netdev-genl.c
11
12 static int
13 netdev_nl_dev_fill(struct net_device *netdev, struct sk_buff *rsp,
14 const struct genl_info *info)
15 {
16 u64 xdp_rx_meta = 0;
17 void *hdr;
18
19 hdr = genlmsg_iput(rsp, info);
20 if (!hdr)
21 return -EMSGSIZE;
22
23 #define XDP_METADATA_KFUNC(_, flag, __, xmo) \
24 if (netdev->xdp_metadata_ops->xmo) \
25 xdp_rx_meta |= flag;
> 26 XDP_METADATA_KFUNC_xxx
27 #undef XDP_METADATA_KFUNC
28
29 if (nla_put_u32(rsp, NETDEV_A_DEV_IFINDEX, netdev->ifindex) ||
30 nla_put_u64_64bit(rsp, NETDEV_A_DEV_XDP_FEATURES,
31 netdev->xdp_features, NETDEV_A_DEV_PAD) ||
32 nla_put_u64_64bit(rsp, NETDEV_A_DEV_XDP_RX_METADATA_FEATURES,
33 xdp_rx_meta, NETDEV_A_DEV_PAD)) {
34 genlmsg_cancel(rsp, hdr);
35 return -EINVAL;
36 }
37
38 if (netdev->xdp_features & NETDEV_XDP_ACT_XSK_ZEROCOPY) {
39 if (nla_put_u32(rsp, NETDEV_A_DEV_XDP_ZC_MAX_SEGS,
40 netdev->xdp_zc_max_segs)) {
41 genlmsg_cancel(rsp, hdr);
42 return -EINVAL;
43 }
44 }
45
46 genlmsg_end(rsp, hdr);
47
48 return 0;
49 }
50
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-09 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 22:58 [PATCH bpf-next 0/3] bpf: expose information about netdev xdp-metadata kfunc support Stanislav Fomichev
2023-09-08 22:58 ` [PATCH bpf-next 1/3] bpf: make it easier to add new metadata kfunc Stanislav Fomichev
2023-09-08 22:58 ` [PATCH bpf-next 2/3] bpf: expose information about supported xdp " Stanislav Fomichev
2023-09-09 11:23 ` kernel test robot [this message]
2023-09-11 22:11 ` Martin KaFai Lau
2023-09-11 22:48 ` Stanislav Fomichev
2023-09-08 22:58 ` [PATCH bpf-next 3/3] tools: ynl: extend netdev sample to dump xdp-rx-metadata-features Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309091923.UTfYFF4J-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).