Re: [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW offloading for KSZ9477

Lukasz Majewski
2023-09-14T21:18:41Z

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

Hi Vladimir,

> On Wed, Sep 13, 2023 at 04:51:02PM +0300, Vladimir Oltean wrote:
> > > I'm really stunned, how much extra work is required to add two
> > > callbacks to DSA subsystem (to have already implemented feature)
> > > for a single chip IC.
> >
> > Some observations are best kept to yourself. This is only the
> > second HSR offload in the entire kernel. To complain that the
> > infrastructure needs some extensions, for something that wasn't
> > even needed for the first implementation (tracking a MAC address),
> > is unrealistic.
>
> Can you please test the attached incremental patch, which applies on
> top of your RFC v4 series? It contains an implementation of my own
> review feedback.

Thanks for preparing the patch - it clarified all the point from
previous e-mails... (and shed some light on mine understanding of DSA
internals)

It works when applied on top of v4. No performance regressions (with
nuttcp) observed.

I've also tested the scenario when one tried to alter lan1 after HW
offloading enabled. It was not possible to alter the MAC address.

As fair as I understood from the commit message - some part of this
patch needs to be applied before HSR offloading v4.

Hence I will wait for it to be posted and upstreamed.

Only then some of this patch code would be squashed to v5 of hsr
support.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]