From: "Köry Maincent" <kory.maincent@bootlin.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: PoE support
Date: Tue, 12 Sep 2023 12:26:55 +0200 [thread overview]
Message-ID: <20230912122655.391e2c86@kmaincent-XPS-13-7390> (raw)
Hello,
I am working on the PoE support and I am facing few questioning.
I would like to use the same commands and core as PoDL, but non generic
development raised questions.
The admin_state and admin_control are the same therefore I will use the
ethtool_podl_pse_admin_state enumeration.
The power detection status have few differences, I thought that adding PoE
specific states to ethtool_podl_pse_pw_d_status rather than adding a new
ethtool_pse_pw_d_status enum is the best way to avoid breaking the old API.
I also would like to remove PoDL reference to ethtool but keep
"podl-pse-admin-control" command for old compatibility alongside a new
"pse-admin-control" command.
What do you think? Do you think of a better way?
Köry
next reply other threads:[~2023-09-12 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 10:26 Köry Maincent [this message]
2023-09-12 11:06 ` PoE support Oleksij Rempel
2023-09-12 13:25 ` Köry Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912122655.391e2c86@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox