netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] ipv6: fix ip6_sock_set_addr_preferences() typo
@ 2023-09-11 15:42 Eric Dumazet
  2023-09-12 14:56 ` Simon Horman
  2023-09-12 16:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2023-09-11 15:42 UTC (permalink / raw)
  To: David S . Miller, Jakub Kicinski, Paolo Abeni
  Cc: netdev, eric.dumazet, Eric Dumazet, Christoph Hellwig,
	Chuck Lever

ip6_sock_set_addr_preferences() second argument should be an integer.

SUNRPC attempts to set IPV6_PREFER_SRC_PUBLIC were
translated to IPV6_PREFER_SRC_TMP

Fixes: 18d5ad623275 ("ipv6: add ip6_sock_set_addr_preferences")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Chuck Lever <chuck.lever@oracle.com>
---
 include/net/ipv6.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index 0675be0f3fa0efc55575bb5b2569dc8a1dbb9f24..fe274c122a563ce3a11b03e49ee71780b3dbda96 100644
--- a/include/net/ipv6.h
+++ b/include/net/ipv6.h
@@ -1360,7 +1360,7 @@ static inline int __ip6_sock_set_addr_preferences(struct sock *sk, int val)
 	return 0;
 }
 
-static inline int ip6_sock_set_addr_preferences(struct sock *sk, bool val)
+static inline int ip6_sock_set_addr_preferences(struct sock *sk, int val)
 {
 	int ret;
 
-- 
2.42.0.283.g2d96d420d3-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] ipv6: fix ip6_sock_set_addr_preferences() typo
  2023-09-11 15:42 [PATCH net] ipv6: fix ip6_sock_set_addr_preferences() typo Eric Dumazet
@ 2023-09-12 14:56 ` Simon Horman
  2023-09-12 16:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-09-12 14:56 UTC (permalink / raw)
  To: Eric Dumazet
  Cc: David S. Miller, Jakub Kicinski, Paolo Abeni, netdev,
	eric.dumazet, Christoph Hellwig, Chuck Lever

On Mon, Sep 11, 2023 at 03:42:13PM +0000, Eric Dumazet wrote:
> ip6_sock_set_addr_preferences() second argument should be an integer.
> 
> SUNRPC attempts to set IPV6_PREFER_SRC_PUBLIC were
> translated to IPV6_PREFER_SRC_TMP
> 
> Fixes: 18d5ad623275 ("ipv6: add ip6_sock_set_addr_preferences")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Chuck Lever <chuck.lever@oracle.com>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] ipv6: fix ip6_sock_set_addr_preferences() typo
  2023-09-11 15:42 [PATCH net] ipv6: fix ip6_sock_set_addr_preferences() typo Eric Dumazet
  2023-09-12 14:56 ` Simon Horman
@ 2023-09-12 16:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-12 16:50 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: davem, kuba, pabeni, netdev, eric.dumazet, hch, chuck.lever

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Mon, 11 Sep 2023 15:42:13 +0000 you wrote:
> ip6_sock_set_addr_preferences() second argument should be an integer.
> 
> SUNRPC attempts to set IPV6_PREFER_SRC_PUBLIC were
> translated to IPV6_PREFER_SRC_TMP
> 
> Fixes: 18d5ad623275 ("ipv6: add ip6_sock_set_addr_preferences")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Chuck Lever <chuck.lever@oracle.com>
> 
> [...]

Here is the summary with links:
  - [net] ipv6: fix ip6_sock_set_addr_preferences() typo
    https://git.kernel.org/netdev/net/c/8cdd9f1aaedf

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-12 16:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-11 15:42 [PATCH net] ipv6: fix ip6_sock_set_addr_preferences() typo Eric Dumazet
2023-09-12 14:56 ` Simon Horman
2023-09-12 16:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).