From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: [PATCH net-next 00/14] ipv6: round of data-races fixes
Date: Tue, 12 Sep 2023 16:01:58 +0000 [thread overview]
Message-ID: <20230912160212.3467976-1-edumazet@google.com> (raw)
This series is inspired by one related syzbot report.
Many inet6_sk(sk) fields reads or writes are racy.
Move 1-bit fields to inet->inet_flags to provide
atomic safety. inet6_{test|set|clear|assign}_bit() helpers
could be changed later if we need to make room in inet_flags.
Also add missing READ_ONCE()/WRITE_ONCE() when
lockless readers need access to specific fields.
np->srcprefs will be handled separately to avoid merge conflicts
because a prior patch was posted for net tree.
Eric Dumazet (14):
ipv6: lockless IPV6_UNICAST_HOPS implementation
ipv6: lockless IPV6_MULTICAST_LOOP implementation
ipv6: lockless IPV6_MULTICAST_HOPS implementation
ipv6: lockless IPV6_MTU implementation
ipv6: lockless IPV6_MINHOPCOUNT implementation
ipv6: lockless IPV6_RECVERR_RFC4884 implementation
ipv6: lockless IPV6_MULTICAST_ALL implementation
ipv6: lockless IPV6_AUTOFLOWLABEL implementation
ipv6: lockless IPV6_DONTFRAG implementation
ipv6: lockless IPV6_RECVERR implemetation
ipv6: move np->repflow to atomic flags
ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation
ipv6: lockless IPV6_MTU_DISCOVER implementation
ipv6: lockless IPV6_FLOWINFO_SEND implementation
include/linux/ipv6.h | 49 +++----
include/net/inet_sock.h | 10 ++
include/net/ip6_route.h | 14 +-
include/net/ipv6.h | 16 +--
include/net/sock.h | 2 +-
include/net/xfrm.h | 2 +-
net/core/sock.c | 4 +-
net/dccp/ipv6.c | 8 +-
net/ipv4/ping.c | 5 +-
net/ipv6/af_inet6.c | 9 +-
net/ipv6/datagram.c | 15 +--
net/ipv6/icmp.c | 4 +-
net/ipv6/ip6_flowlabel.c | 8 +-
net/ipv6/ip6_output.c | 42 +++---
net/ipv6/ipv6_sockglue.c | 223 +++++++++++++++-----------------
net/ipv6/mcast.c | 4 +-
net/ipv6/ndisc.c | 4 +-
net/ipv6/ping.c | 4 +-
net/ipv6/raw.c | 16 +--
net/ipv6/tcp_ipv6.c | 21 ++-
net/ipv6/udp.c | 12 +-
net/l2tp/l2tp_ip6.c | 6 +-
net/netfilter/ipvs/ip_vs_sync.c | 12 +-
net/sctp/ipv6.c | 7 +-
24 files changed, 238 insertions(+), 259 deletions(-)
--
2.42.0.283.g2d96d420d3-goog
next reply other threads:[~2023-09-12 16:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 16:01 Eric Dumazet [this message]
2023-09-12 16:01 ` [PATCH net-next 01/14] ipv6: lockless IPV6_UNICAST_HOPS implementation Eric Dumazet
2023-09-14 14:51 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 02/14] ipv6: lockless IPV6_MULTICAST_LOOP implementation Eric Dumazet
2023-09-14 14:54 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 03/14] ipv6: lockless IPV6_MULTICAST_HOPS implementation Eric Dumazet
2023-09-14 14:55 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 04/14] ipv6: lockless IPV6_MTU implementation Eric Dumazet
2023-09-14 14:58 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 05/14] ipv6: lockless IPV6_MINHOPCOUNT implementation Eric Dumazet
2023-09-14 15:01 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 06/14] ipv6: lockless IPV6_RECVERR_RFC4884 implementation Eric Dumazet
2023-09-14 15:02 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 07/14] ipv6: lockless IPV6_MULTICAST_ALL implementation Eric Dumazet
2023-09-14 15:03 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 08/14] ipv6: lockless IPV6_AUTOFLOWLABEL implementation Eric Dumazet
2023-09-14 15:04 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 09/14] ipv6: lockless IPV6_DONTFRAG implementation Eric Dumazet
2023-09-14 15:05 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 10/14] ipv6: lockless IPV6_RECVERR implemetation Eric Dumazet
2023-09-14 15:06 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 11/14] ipv6: move np->repflow to atomic flags Eric Dumazet
2023-09-14 15:07 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 12/14] ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation Eric Dumazet
2023-09-14 15:08 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 13/14] ipv6: lockless IPV6_MTU_DISCOVER implementation Eric Dumazet
2023-09-14 15:10 ` David Ahern
2023-09-12 16:02 ` [PATCH net-next 14/14] ipv6: lockless IPV6_FLOWINFO_SEND implementation Eric Dumazet
2023-09-14 15:11 ` David Ahern
2023-09-14 10:25 ` [PATCH net-next 00/14] ipv6: round of data-races fixes Simon Horman
2023-09-15 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912160212.3467976-1-edumazet@google.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).