* [PATCH] net: ti: icssg-prueth: add PTP dependency
@ 2023-09-12 18:54 Arnd Bergmann
2023-09-13 6:24 ` MD Danish Anwar
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-09-12 18:54 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran, Vignesh Raghavendra, Grygorii Strashko,
MD Danish Anwar, Roger Quadros
Cc: Arnd Bergmann, Simon Horman, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The driver can now use PTP if enabled but fails to link built-in
if PTP is a loadable module:
aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
Add the usual dependency to avoid this.
Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 7f3e2e96c6e20..26ddc26fc7b8d 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -201,6 +201,7 @@ config TI_ICSSG_PRUETH
config TI_ICSS_IEP
tristate "TI PRU ICSS IEP driver"
+ depends on PTP_1588_CLOCK_OPTIONAL
depends on TI_PRUSS
default TI_PRUSS
help
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] net: ti: icssg-prueth: add PTP dependency
2023-09-12 18:54 [PATCH] net: ti: icssg-prueth: add PTP dependency Arnd Bergmann
@ 2023-09-13 6:24 ` MD Danish Anwar
2023-09-13 7:58 ` Jiri Pirko
2023-09-15 9:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: MD Danish Anwar @ 2023-09-13 6:24 UTC (permalink / raw)
To: Arnd Bergmann, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Richard Cochran, Vignesh Raghavendra,
Grygorii Strashko, Roger Quadros
Cc: Arnd Bergmann, Simon Horman, netdev, linux-kernel
On 13/09/23 00:24, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver can now use PTP if enabled but fails to link built-in
> if PTP is a loadable module:
>
> aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
> icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
>
> Add the usual dependency to avoid this.
>
> Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> drivers/net/ethernet/ti/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index 7f3e2e96c6e20..26ddc26fc7b8d 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -201,6 +201,7 @@ config TI_ICSSG_PRUETH
>
> config TI_ICSS_IEP
> tristate "TI PRU ICSS IEP driver"
> + depends on PTP_1588_CLOCK_OPTIONAL
> depends on TI_PRUSS
> default TI_PRUSS
> help
--
Thanks and Regards,
Danish
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: ti: icssg-prueth: add PTP dependency
2023-09-12 18:54 [PATCH] net: ti: icssg-prueth: add PTP dependency Arnd Bergmann
2023-09-13 6:24 ` MD Danish Anwar
@ 2023-09-13 7:58 ` Jiri Pirko
2023-09-15 9:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2023-09-13 7:58 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran, Vignesh Raghavendra, Grygorii Strashko,
MD Danish Anwar, Roger Quadros, Arnd Bergmann, Simon Horman,
netdev, linux-kernel
Tue, Sep 12, 2023 at 08:54:51PM CEST, arnd@kernel.org wrote:
>From: Arnd Bergmann <arnd@arndb.de>
>
>The driver can now use PTP if enabled but fails to link built-in
>if PTP is a loadable module:
>
>aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
>icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
>
>Add the usual dependency to avoid this.
>
>Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: ti: icssg-prueth: add PTP dependency
2023-09-12 18:54 [PATCH] net: ti: icssg-prueth: add PTP dependency Arnd Bergmann
2023-09-13 6:24 ` MD Danish Anwar
2023-09-13 7:58 ` Jiri Pirko
@ 2023-09-15 9:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-15 9:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: davem, edumazet, kuba, pabeni, richardcochran, vigneshr,
grygorii.strashko, danishanwar, rogerq, arnd, horms, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 12 Sep 2023 20:54:51 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver can now use PTP if enabled but fails to link built-in
> if PTP is a loadable module:
>
> aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
> icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'
>
> [...]
Here is the summary with links:
- net: ti: icssg-prueth: add PTP dependency
https://git.kernel.org/netdev/net/c/a8f367f7e131
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-15 9:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-12 18:54 [PATCH] net: ti: icssg-prueth: add PTP dependency Arnd Bergmann
2023-09-13 6:24 ` MD Danish Anwar
2023-09-13 7:58 ` Jiri Pirko
2023-09-15 9:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).