From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1705A1D524
	for <netdev@vger.kernel.org>; Thu, 14 Sep 2023 10:26:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D93CC433C8;
	Thu, 14 Sep 2023 10:26:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1694687164;
	bh=y38loyGQg6GHCvGEMW1DVfwqr90xmnw3mOxNq3q890Y=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=CKDCUJ+S70fzVxBgXMd6f5LgH4LN0s0fLZHUD1C+M9SoyDLILoblXbJCq/6GR8Sli
	 ecyH2cyRpFdEXkI71Et0ySbLjlmNVwE5ya/1hWGYozTE6xHghQZxaF097GWJx2PUpN
	 kz+wS5Qhyl6EcGTkMR2T9ad0HkMdAvBbLprPLLe421fs75rGxjHLjaLEOhhezVPMOV
	 gxph54cPk/pTZFoDc6ATKqoFQD+qrZMkl9H6nhx1WvfX6+xvp6g1vUx3DRXjAxc4LP
	 w4O14C1S0J4+dgCifGTT8x0NR84NnvElkgTJcCbtLM1/Lb9aB1etH8TZO2NUPi6lBi
	 xh2HX6qF8MyQA==
Date: Thu, 14 Sep 2023 12:25:49 +0200
From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	David Ahern <dsahern@kernel.org>, netdev@vger.kernel.org,
	eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 00/14] ipv6: round of data-races fixes
Message-ID: <20230914102549.GW401982@kernel.org>
References: <20230912160212.3467976-1-edumazet@google.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230912160212.3467976-1-edumazet@google.com>

On Tue, Sep 12, 2023 at 04:01:58PM +0000, Eric Dumazet wrote:
> This series is inspired by one related syzbot report.
> 
> Many inet6_sk(sk) fields reads or writes are racy.
> 
> Move 1-bit fields to inet->inet_flags to provide
> atomic safety. inet6_{test|set|clear|assign}_bit() helpers
> could be changed later if we need to make room in inet_flags.
> 
> Also add missing READ_ONCE()/WRITE_ONCE() when
> lockless readers need access to specific fields.
> 
> np->srcprefs will be handled separately to avoid merge conflicts
> because a prior patch was posted for net tree.
> 
> Eric Dumazet (14):
>   ipv6: lockless IPV6_UNICAST_HOPS implementation
>   ipv6: lockless IPV6_MULTICAST_LOOP implementation
>   ipv6: lockless IPV6_MULTICAST_HOPS implementation
>   ipv6: lockless IPV6_MTU implementation
>   ipv6: lockless IPV6_MINHOPCOUNT implementation
>   ipv6: lockless IPV6_RECVERR_RFC4884 implementation
>   ipv6: lockless IPV6_MULTICAST_ALL implementation
>   ipv6: lockless IPV6_AUTOFLOWLABEL implementation
>   ipv6: lockless IPV6_DONTFRAG implementation
>   ipv6: lockless IPV6_RECVERR implemetation
>   ipv6: move np->repflow to atomic flags
>   ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation
>   ipv6: lockless IPV6_MTU_DISCOVER implementation
>   ipv6: lockless IPV6_FLOWINFO_SEND implementation

For series,

Reviewed-by: Simon Horman <horms@kernel.org>