From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@kernel.org>
Cc: nicolas.dichtel@6wind.com, Thomas Haller <thaller@redhat.com>,
Benjamin Poirier <bpoirier@nvidia.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Ido Schimmel <idosch@idosch.org>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib
Date: Fri, 15 Sep 2023 09:59:48 -0700 [thread overview]
Message-ID: <20230915095948.63f9dd69@hermes.local> (raw)
In-Reply-To: <b6837627-27a9-b870-c85b-799c23705a74@kernel.org>
On Wed, 13 Sep 2023 08:41:05 -0600
David Ahern <dsahern@kernel.org> wrote:
> On 9/13/23 1:58 AM, Nicolas Dichtel wrote:
> > Le 11/09/2023 à 11:50, Thomas Haller a écrit :
> > [snip]
> >> - the fact that it isn't fixed in more than a decade, shows IMO that
> >> getting caching right for routes is very hard. Patches that improve the
> >> behavior should not be rejected with "look at libnl3 or FRR".
> > +1
> >
> > I just hit another corner case:
> >
> > ip link set ntfp2 up
> > ip address add 10.125.0.1/24 dev ntfp2
> > ip nexthop add id 1234 via 10.125.0.2 dev ntfp2
> > ip route add 10.200.0.0/24 nhid 1234
> >
> > Check the config:
> > $ ip route
> > <snip>
> > 10.200.0.0/24 nhid 1234 via 10.125.0.2 dev ntfp2
> > $ ip nexthop
> > id 1234 via 10.125.0.2 dev ntfp2 scope link
> >
> >
> > Set the carrier off on ntfp2:
> > ip monitor label link route nexthop&
> > ip link set ntfp2 carrier off
> >
> > $ ip link set ntfp2 carrier off
> > $ [LINK]4: ntfp2: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state
> > DOWN group default
> > link/ether de:ed:02:67:61:1f brd ff:ff:ff:ff:ff:ff
> >
> > => No nexthop event nor route event (net.ipv4.nexthop_compat_mode = 1)
>
> carrier down is a link event and as you show here, link events are sent.
>
> >
> > 'ip nexthop' and 'ip route' show that the nexthop and the route have been deleted.
>
> nexthop objects are removed on the link event; any routes referencing
> those nexthops are removed.
The netlink notification path can and does not have any flow control.
The problem with what is propoosed is that if there are 1M route entries
and a link event happens, some of the RTM_DELROUTE events will be dropped
when the netlink queue overruns. Therefore daemons can not depend on RTM_DELROUTE
for tracking, and instead should look for the link event and do bulk
cleanup then.
next prev parent reply other threads:[~2023-09-15 17:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 8:00 [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib Hangbin Liu
2023-07-18 10:19 ` Ido Schimmel
2023-07-18 10:32 ` Ido Schimmel
2023-07-18 14:45 ` David Ahern
2023-07-18 15:58 ` Stephen Hemminger
2023-07-20 7:51 ` Hangbin Liu
2023-07-20 14:29 ` Ido Schimmel
2023-07-21 1:34 ` Hangbin Liu
2023-07-21 4:01 ` David Ahern
2023-07-21 5:46 ` Hangbin Liu
2023-07-23 7:38 ` Ido Schimmel
2023-07-24 8:56 ` Hangbin Liu
2023-07-24 15:48 ` Stephen Hemminger
2023-07-25 8:20 ` Hangbin Liu
2023-07-25 16:36 ` Stephen Hemminger
2023-07-28 13:01 ` Nicolas Dichtel
2023-07-28 15:42 ` David Ahern
2023-08-02 9:10 ` Thomas Haller
2023-08-08 1:44 ` David Ahern
2023-08-08 18:59 ` Benjamin Poirier
2023-09-11 9:50 ` Thomas Haller
2023-09-13 7:58 ` Nicolas Dichtel
2023-09-13 9:54 ` Hangbin Liu
2023-09-13 14:11 ` Nicolas Dichtel
2023-09-13 14:43 ` David Ahern
2023-09-13 14:53 ` Nicolas Dichtel
2023-09-14 15:43 ` Nicolas Dichtel
2023-09-15 3:07 ` David Ahern
2023-09-15 15:54 ` Nicolas Dichtel
2023-09-13 14:41 ` David Ahern
2023-09-15 16:59 ` Stephen Hemminger [this message]
2023-07-26 10:17 ` [Questions] Some issues about IPv4/IPv6 nexthop route (was Re: [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib) Hangbin Liu
2023-07-26 15:57 ` David Ahern
2023-07-27 4:19 ` [Questions] Some issues about IPv4/IPv6 nexthop route Hangbin Liu
2023-07-27 15:35 ` David Ahern
2023-07-27 14:45 ` [Questions] Some issues about IPv4/IPv6 nexthop route (was Re: [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib) Ido Schimmel
2023-08-28 7:53 ` [Questions] Some issues about IPv4/IPv6 nexthop route Hangbin Liu
2023-08-28 15:06 ` David Ahern
2023-08-29 1:07 ` Hangbin Liu
2023-08-29 1:42 ` David Ahern
2023-08-02 9:06 ` [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib Thomas Haller
2023-08-04 8:09 ` Hangbin Liu
2023-08-09 7:06 ` Ido Schimmel
2023-08-09 10:02 ` Hangbin Liu
2023-07-25 14:13 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915095948.63f9dd69@hermes.local \
--to=stephen@networkplumber.org \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).