public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Tristram.Ha@microchip.com, Eric Dumazet <edumazet@google.com>,
	davem@davemloft.net, Woojung Huh <woojung.huh@microchip.com>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	UNGLinuxDriver@microchip.com,
	Oleksij Rempel <linux@rempel-privat.de>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW offloading for KSZ9477
Date: Fri, 15 Sep 2023 17:22:55 +0300	[thread overview]
Message-ID: <20230915142255.dcosmtrh25nbw5x7@skbuf> (raw)
In-Reply-To: <20230914231831.0f406585@wsk>

On Thu, Sep 14, 2023 at 11:18:31PM +0200, Lukasz Majewski wrote:
> As fair as I understood from the commit message - some part of this
> patch needs to be applied before HSR offloading v4.
> 
> Hence I will wait for it to be posted and upstreamed.
> 
> Only then some of this patch code would be squashed to v5 of hsr
> support.

No, this isn't how this is going to work. I can't post my patches and
then you post yours, because that would mean some functionality is
introduced without a user (ds->ops->port_set_mac_address), and we don't
accept that, because you may or may not resubmit your HSR patches as a
first user of the new infra.

So, what needs to happen is you need to post all the patches as an
all-or-nothing series. Somewhere in Documentation/process/ it is
probably explained in more detail what to pay attention to, when reposting
what is partly others' work. But the basic idea is that you need to keep
the Author: and Signed-off-by: fields if you aren't making major changes,
but you must also add your own Signed-off-by: at the end. You also have
responsibility for the patches that you post, and have to respond to
review feedback, even if they aren't authored for you. You are obviously
free to make changes to patches until they pass your own criteria.

The most that I can do to help you is to split that squashed patch and
put the result on a branch:
https://github.com/vladimiroltean/linux/commits/lukma-ksz-hsr-rfc-v4

But it's up to you to take it from there, rebase it on net-next, review
the result, test it, make sure that the changes are something that you
can justify when submitting, etc. You won't be alone if you need help,
of course, but the point is that you're not 100% passive to this activity.

  reply	other threads:[~2023-09-15 14:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 15:27 [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW offloading for KSZ9477 Lukasz Majewski
2023-09-06 15:28 ` [[RFC PATCH v4 net-next] 1/2] net: dsa: Extend ksz9477 TAG setup to support HSR frames duplication Lukasz Majewski
2023-09-06 15:28 ` [[RFC PATCH v4 net-next] 2/2] net: dsa: hsr: Enable in KSZ9477 switch HW HSR offloading Lukasz Majewski
2023-09-11 14:58 ` [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW offloading for KSZ9477 Lukasz Majewski
2023-09-11 16:05   ` Vladimir Oltean
2023-09-11 17:02     ` Vladimir Oltean
2023-09-11 17:03       ` Vladimir Oltean
2023-10-03 13:34       ` Jakub Kicinski
2023-09-12  8:17     ` Lukasz Majewski
2023-09-12  9:29       ` Vladimir Oltean
2023-09-12 14:03         ` Lukasz Majewski
2023-09-12 14:26           ` Vladimir Oltean
2023-09-12 15:06             ` Lukasz Majewski
2023-09-12 21:55               ` Vladimir Oltean
2023-09-13  8:22                 ` Lukasz Majewski
2023-09-13 10:58                   ` Vladimir Oltean
2023-09-13 12:15                     ` Lukasz Majewski
2023-09-13 13:51                       ` Vladimir Oltean
2023-09-13 18:42                         ` Vladimir Oltean
2023-09-14 21:18                           ` Lukasz Majewski
2023-09-15 14:22                             ` Vladimir Oltean [this message]
2023-09-18  9:06                               ` Lukasz Majewski
2023-09-14 20:45                         ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230915142255.dcosmtrh25nbw5x7@skbuf \
    --to=olteanv@gmail.com \
    --cc=Tristram.Ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=lukma@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox