From: Heng Qi <hengqi@linux.alibaba.com>
To: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Gavin Li <gavinl@nvidia.com>
Subject: [PATCH net 2/6] virtio-net: fix mismatch of getting tx-frames
Date: Tue, 19 Sep 2023 15:49:11 +0800 [thread overview]
Message-ID: <20230919074915.103110-3-hengqi@linux.alibaba.com> (raw)
In-Reply-To: <20230919074915.103110-1-hengqi@linux.alibaba.com>
Since virtio-net allows switching napi_tx for per txq, we have to
get the specific txq's result now.
Fixes: 394bd87764b6 ("virtio_net: support per queue interrupt coalesce command")
Cc: Gavin Li <gavinl@nvidia.com>
Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>
---
drivers/net/virtio_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index fd5bc8d59eda..80d35a864790 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -3453,7 +3453,7 @@ static int virtnet_get_per_queue_coalesce(struct net_device *dev,
} else {
ec->rx_max_coalesced_frames = 1;
- if (vi->sq[0].napi.weight)
+ if (vi->sq[queue].napi.weight)
ec->tx_max_coalesced_frames = 1;
}
--
2.19.1.6.gb485710b
next prev parent reply other threads:[~2023-09-19 7:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 7:49 [PATCH net 0/6] virtio-net: Fix and update interrupt moderation Heng Qi
2023-09-19 7:49 ` [PATCH net 1/6] virtio-net: initially change the value of tx-frames Heng Qi
2023-09-21 7:03 ` Jason Wang
2023-09-19 7:49 ` Heng Qi [this message]
2023-09-22 3:11 ` [PATCH net 2/6] virtio-net: fix mismatch of getting tx-frames Jason Wang
2023-09-19 7:49 ` [PATCH net 3/6] virtio-net: consistently save parameters for per-queue Heng Qi
2023-09-22 4:26 ` Jason Wang
2023-09-19 7:49 ` [PATCH net 4/6] virtio-net: fix per queue coalescing parameter setting Heng Qi
2023-09-22 4:27 ` Jason Wang
2023-09-19 7:49 ` [PATCH net 5/6] virtio-net: fix the vq coalescing setting for vq resize Heng Qi
2023-09-22 4:29 ` Jason Wang
2023-09-22 5:02 ` Heng Qi
2023-09-22 7:32 ` Jason Wang
2023-09-22 7:58 ` Heng Qi
2023-09-25 2:29 ` Jason Wang
2023-09-25 2:47 ` Heng Qi
2023-09-22 9:50 ` Xuan Zhuo
2023-09-25 2:29 ` Jason Wang
2023-09-25 2:45 ` Heng Qi
2023-09-19 7:49 ` [PATCH net 6/6] virtio-net: a tiny comment update Heng Qi
2023-09-22 4:30 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919074915.103110-3-hengqi@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gavinl@nvidia.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox