netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, nharold@google.com, lorenzo@google.com,
	benedictwong@google.com, steffen.klassert@secunet.com,
	herbert@gondor.apana.org.au
Subject: Re: [PATCH ipsec-next 0/2] xfrm: policy: replace session decode with flow dissector
Date: Thu, 21 Sep 2023 13:22:08 +0100	[thread overview]
Message-ID: <20230921122208.GL224399@kernel.org> (raw)
In-Reply-To: <20230918125914.21391-1-fw@strlen.de>

On Mon, Sep 18, 2023 at 02:59:07PM +0200, Florian Westphal wrote:
> Remove the ipv4+ipv6 session decode functions and use generic flow
> dissector to populate the flowi for the policy lookup.
> 
> Changes since RFC:
> 
>  - Drop mobility header support.  I don't think that anyone uses
>    this.  MOBIKE doesn't appear to need this either.
>  - Drop fl6->flowlabel assignment, original code leaves it as 0.
> 
> There is no reason for this change other than to remove code.
> 
> Florian Westphal (2):
>   xfrm: move mark and oif flowi decode into common code
>   xfrm: policy: replace session decode with flow dissector
> 
> Florian Westphal (2):
>   xfrm: move mark and oif flowi decode into common code
>   xfrm: policy: replace session decode with flow dissector
> 
>  net/xfrm/xfrm_policy.c | 277 ++++++++++++++++-------------------------
>  1 file changed, 107 insertions(+), 170 deletions(-)

For series,

Reviewed-by: Simon Horman <horms@kernel.org>


      parent reply	other threads:[~2023-09-21 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 12:59 [PATCH ipsec-next 0/2] xfrm: policy: replace session decode with flow dissector Florian Westphal
2023-09-18 12:59 ` [PATCH ipsec-next 1/2] xfrm: move mark and oif flowi decode into common code Florian Westphal
2023-09-18 12:59 ` [PATCH ipsec-next 2/2] xfrm: policy: replace session decode with flow dissector Florian Westphal
2023-09-27  8:47   ` kernel test robot
2023-09-27 18:01     ` Florian Westphal
2023-09-21 12:22 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230921122208.GL224399@kernel.org \
    --to=horms@kernel.org \
    --cc=benedictwong@google.com \
    --cc=fw@strlen.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nharold@google.com \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).