* [PATCH net-next] ethernet/intel: Use list_for_each_entry() helper
@ 2023-09-19 17:04 Tony Nguyen
2023-09-21 14:58 ` Simon Horman
2023-09-28 10:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: Tony Nguyen @ 2023-09-19 17:04 UTC (permalink / raw)
To: davem, kuba, pabeni, edumazet, netdev
Cc: Jinjie Ruan, anthony.l.nguyen, Jacob Keller, Rafal Romanowski
From: Jinjie Ruan <ruanjinjie@huawei.com>
Convert list_for_each() to list_for_each_entry() where applicable.
No functional changed.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 7 ++-----
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 7 ++-----
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 76b34cee1da3..2ac9dffd0bf8 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7857,7 +7857,6 @@ static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
{
struct pci_dev *pdev = adapter->pdev;
struct vf_data_storage *vf_data = &adapter->vf_data[vf];
- struct list_head *pos;
struct vf_mac_filter *entry = NULL;
int ret = 0;
@@ -7878,8 +7877,7 @@ static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
switch (info) {
case E1000_VF_MAC_FILTER_CLR:
/* remove all unicast MAC filters related to the current VF */
- list_for_each(pos, &adapter->vf_macs.l) {
- entry = list_entry(pos, struct vf_mac_filter, l);
+ list_for_each_entry(entry, &adapter->vf_macs.l, l) {
if (entry->vf == vf) {
entry->vf = -1;
entry->free = true;
@@ -7889,8 +7887,7 @@ static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
break;
case E1000_VF_MAC_FILTER_ADD:
/* try to find empty slot in the list */
- list_for_each(pos, &adapter->vf_macs.l) {
- entry = list_entry(pos, struct vf_mac_filter, l);
+ list_for_each_entry(entry, &adapter->vf_macs.l, l) {
if (entry->free)
break;
}
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 29cc60988071..4c6e2a485d8e 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -639,12 +639,10 @@ static int ixgbe_set_vf_macvlan(struct ixgbe_adapter *adapter,
int vf, int index, unsigned char *mac_addr)
{
struct vf_macvlans *entry;
- struct list_head *pos;
int retval = 0;
if (index <= 1) {
- list_for_each(pos, &adapter->vf_mvs.l) {
- entry = list_entry(pos, struct vf_macvlans, l);
+ list_for_each_entry(entry, &adapter->vf_mvs.l, l) {
if (entry->vf == vf) {
entry->vf = -1;
entry->free = true;
@@ -664,8 +662,7 @@ static int ixgbe_set_vf_macvlan(struct ixgbe_adapter *adapter,
entry = NULL;
- list_for_each(pos, &adapter->vf_mvs.l) {
- entry = list_entry(pos, struct vf_macvlans, l);
+ list_for_each_entry(entry, &adapter->vf_mvs.l, l) {
if (entry->free)
break;
}
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] ethernet/intel: Use list_for_each_entry() helper
2023-09-19 17:04 [PATCH net-next] ethernet/intel: Use list_for_each_entry() helper Tony Nguyen
@ 2023-09-21 14:58 ` Simon Horman
2023-09-28 10:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: Simon Horman @ 2023-09-21 14:58 UTC (permalink / raw)
To: Tony Nguyen
Cc: davem, kuba, pabeni, edumazet, netdev, Jinjie Ruan, Jacob Keller,
Rafal Romanowski
On Tue, Sep 19, 2023 at 10:04:09AM -0700, Tony Nguyen wrote:
> From: Jinjie Ruan <ruanjinjie@huawei.com>
>
> Convert list_for_each() to list_for_each_entry() where applicable.
>
> No functional changed.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] ethernet/intel: Use list_for_each_entry() helper
2023-09-19 17:04 [PATCH net-next] ethernet/intel: Use list_for_each_entry() helper Tony Nguyen
2023-09-21 14:58 ` Simon Horman
@ 2023-09-28 10:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-28 10:20 UTC (permalink / raw)
To: Tony Nguyen
Cc: davem, kuba, pabeni, edumazet, netdev, ruanjinjie, jacob.e.keller,
rafal.romanowski
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 19 Sep 2023 10:04:09 -0700 you wrote:
> From: Jinjie Ruan <ruanjinjie@huawei.com>
>
> Convert list_for_each() to list_for_each_entry() where applicable.
>
> No functional changed.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
>
> [...]
Here is the summary with links:
- [net-next] ethernet/intel: Use list_for_each_entry() helper
https://git.kernel.org/netdev/net-next/c/c1fec890458a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net-next] ethernet/intel: Use list_for_each_entry() helper
@ 2023-08-21 13:42 Jinjie Ruan
2023-08-23 19:55 ` Jacob Keller
0 siblings, 1 reply; 5+ messages in thread
From: Jinjie Ruan @ 2023-08-21 13:42 UTC (permalink / raw)
To: intel-wired-lan, netdev, Jesse Brandeburg, Tony Nguyen,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: ruanjinjie
Convert list_for_each() to list_for_each_entry() where applicable.
No functional changed.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 7 ++-----
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 7 ++-----
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 9f63a10c6f80..bf9c2f6a1164 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7850,7 +7850,6 @@ static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
{
struct pci_dev *pdev = adapter->pdev;
struct vf_data_storage *vf_data = &adapter->vf_data[vf];
- struct list_head *pos;
struct vf_mac_filter *entry = NULL;
int ret = 0;
@@ -7871,8 +7870,7 @@ static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
switch (info) {
case E1000_VF_MAC_FILTER_CLR:
/* remove all unicast MAC filters related to the current VF */
- list_for_each(pos, &adapter->vf_macs.l) {
- entry = list_entry(pos, struct vf_mac_filter, l);
+ list_for_each_entry(entry, &adapter->vf_macs.l, l) {
if (entry->vf == vf) {
entry->vf = -1;
entry->free = true;
@@ -7882,8 +7880,7 @@ static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
break;
case E1000_VF_MAC_FILTER_ADD:
/* try to find empty slot in the list */
- list_for_each(pos, &adapter->vf_macs.l) {
- entry = list_entry(pos, struct vf_mac_filter, l);
+ list_for_each_entry(entry, &adapter->vf_macs.l, l) {
if (entry->free)
break;
}
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 29cc60988071..4c6e2a485d8e 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -639,12 +639,10 @@ static int ixgbe_set_vf_macvlan(struct ixgbe_adapter *adapter,
int vf, int index, unsigned char *mac_addr)
{
struct vf_macvlans *entry;
- struct list_head *pos;
int retval = 0;
if (index <= 1) {
- list_for_each(pos, &adapter->vf_mvs.l) {
- entry = list_entry(pos, struct vf_macvlans, l);
+ list_for_each_entry(entry, &adapter->vf_mvs.l, l) {
if (entry->vf == vf) {
entry->vf = -1;
entry->free = true;
@@ -664,8 +662,7 @@ static int ixgbe_set_vf_macvlan(struct ixgbe_adapter *adapter,
entry = NULL;
- list_for_each(pos, &adapter->vf_mvs.l) {
- entry = list_entry(pos, struct vf_macvlans, l);
+ list_for_each_entry(entry, &adapter->vf_mvs.l, l) {
if (entry->free)
break;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] ethernet/intel: Use list_for_each_entry() helper
2023-08-21 13:42 Jinjie Ruan
@ 2023-08-23 19:55 ` Jacob Keller
0 siblings, 0 replies; 5+ messages in thread
From: Jacob Keller @ 2023-08-23 19:55 UTC (permalink / raw)
To: Jinjie Ruan, intel-wired-lan, netdev, Jesse Brandeburg,
Tony Nguyen, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On 8/21/2023 6:42 AM, Jinjie Ruan wrote:
> Convert list_for_each() to list_for_each_entry() where applicable.
>
> No functional changed.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Thanks for cleaning these up!
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 7 ++-----
> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 7 ++-----
> 2 files changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 9f63a10c6f80..bf9c2f6a1164 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -7850,7 +7850,6 @@ static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
> {
> struct pci_dev *pdev = adapter->pdev;
> struct vf_data_storage *vf_data = &adapter->vf_data[vf];
> - struct list_head *pos;
> struct vf_mac_filter *entry = NULL;
> int ret = 0;
>
> @@ -7871,8 +7870,7 @@ static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
> switch (info) {
> case E1000_VF_MAC_FILTER_CLR:
> /* remove all unicast MAC filters related to the current VF */
> - list_for_each(pos, &adapter->vf_macs.l) {
> - entry = list_entry(pos, struct vf_mac_filter, l);
> + list_for_each_entry(entry, &adapter->vf_macs.l, l) {
> if (entry->vf == vf) {
> entry->vf = -1;
> entry->free = true;
> @@ -7882,8 +7880,7 @@ static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
> break;
> case E1000_VF_MAC_FILTER_ADD:
> /* try to find empty slot in the list */
> - list_for_each(pos, &adapter->vf_macs.l) {
> - entry = list_entry(pos, struct vf_mac_filter, l);
> + list_for_each_entry(entry, &adapter->vf_macs.l, l) {
> if (entry->free)
> break;
> }
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> index 29cc60988071..4c6e2a485d8e 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> @@ -639,12 +639,10 @@ static int ixgbe_set_vf_macvlan(struct ixgbe_adapter *adapter,
> int vf, int index, unsigned char *mac_addr)
> {
> struct vf_macvlans *entry;
> - struct list_head *pos;
> int retval = 0;
>
> if (index <= 1) {
> - list_for_each(pos, &adapter->vf_mvs.l) {
> - entry = list_entry(pos, struct vf_macvlans, l);
> + list_for_each_entry(entry, &adapter->vf_mvs.l, l) {
> if (entry->vf == vf) {
> entry->vf = -1;
> entry->free = true;
> @@ -664,8 +662,7 @@ static int ixgbe_set_vf_macvlan(struct ixgbe_adapter *adapter,
>
> entry = NULL;
>
> - list_for_each(pos, &adapter->vf_mvs.l) {
> - entry = list_entry(pos, struct vf_macvlans, l);
> + list_for_each_entry(entry, &adapter->vf_mvs.l, l) {
> if (entry->free)
> break;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-28 10:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-19 17:04 [PATCH net-next] ethernet/intel: Use list_for_each_entry() helper Tony Nguyen
2023-09-21 14:58 ` Simon Horman
2023-09-28 10:20 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2023-08-21 13:42 Jinjie Ruan
2023-08-23 19:55 ` Jacob Keller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).