From: kernel test robot <lkp@intel.com>
To: Daan De Meyer <daan.j.demeyer@gmail.com>, bpf@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Daan De Meyer <daan.j.demeyer@gmail.com>,
martin.lau@linux.dev, kernel-team@meta.com,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v5 3/9] bpf: Add bpf_sock_addr_set_unix_addr() to allow writing unix sockaddr from bpf
Date: Sat, 23 Sep 2023 13:19:42 +0800 [thread overview]
Message-ID: <202309231339.L2O0CrMU-lkp@intel.com> (raw)
In-Reply-To: <20230921120913.566702-4-daan.j.demeyer@gmail.com>
Hi Daan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Daan-De-Meyer/selftests-bpf-Add-missing-section-name-tests-for-getpeername-getsockname/20230922-032515
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20230921120913.566702-4-daan.j.demeyer%40gmail.com
patch subject: [PATCH bpf-next v5 3/9] bpf: Add bpf_sock_addr_set_unix_addr() to allow writing unix sockaddr from bpf
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20230923/202309231339.L2O0CrMU-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230923/202309231339.L2O0CrMU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309231339.L2O0CrMU-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/core/filter.c:11731:17: warning: no previous declaration for 'bpf_dynptr_from_skb' [-Wmissing-declarations]
__bpf_kfunc int bpf_dynptr_from_skb(struct sk_buff *skb, u64 flags,
^~~~~~~~~~~~~~~~~~~
net/core/filter.c:11744:17: warning: no previous declaration for 'bpf_dynptr_from_xdp' [-Wmissing-declarations]
__bpf_kfunc int bpf_dynptr_from_xdp(struct xdp_buff *xdp, u64 flags,
^~~~~~~~~~~~~~~~~~~
>> net/core/filter.c:11757:17: warning: no previous declaration for 'bpf_sock_addr_set_unix_addr' [-Wmissing-declarations]
__bpf_kfunc int bpf_sock_addr_set_unix_addr(struct bpf_sock_addr_kern *sa_kern,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
net/core/filter.c:11860:17: warning: no previous declaration for 'bpf_sock_destroy' [-Wmissing-declarations]
__bpf_kfunc int bpf_sock_destroy(struct sock_common *sock)
^~~~~~~~~~~~~~~~
vim +/bpf_sock_addr_set_unix_addr +11757 net/core/filter.c
11756
11757 __bpf_kfunc int bpf_sock_addr_set_unix_addr(struct bpf_sock_addr_kern *sa_kern,
11758 const u8 *addr, u32 addrlen__sz)
11759 {
11760 struct sockaddr *sa = sa_kern->uaddr;
11761 struct sockaddr_un *un;
11762
11763 if (sa_kern->sk->sk_family != AF_UNIX)
11764 return -EINVAL;
11765
11766 /* We do not allow changing the address of unnamed unix sockets. */
11767 if (addrlen__sz == 0 || addrlen__sz > UNIX_PATH_MAX)
11768 return -EINVAL;
11769
11770 un = (struct sockaddr_un *)sa;
11771 memcpy(un->sun_path, addr, addrlen__sz);
11772 sa_kern->uaddrlen = offsetof(struct sockaddr_un, sun_path) + addrlen__sz;
11773
11774 return 0;
11775 }
11776 __diag_pop();
11777
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-23 5:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 12:09 [PATCH bpf-next v5 0/9] Add cgroup sockaddr hooks for unix sockets Daan De Meyer
2023-09-21 12:09 ` [PATCH bpf-next v5 1/9] selftests/bpf: Add missing section name tests for getpeername/getsockname Daan De Meyer
2023-09-21 12:09 ` [PATCH bpf-next v5 2/9] bpf: Propagate modified uaddrlen from cgroup sockaddr programs Daan De Meyer
2023-09-22 2:59 ` kernel test robot
2023-09-21 12:09 ` [PATCH bpf-next v5 3/9] bpf: Add bpf_sock_addr_set_unix_addr() to allow writing unix sockaddr from bpf Daan De Meyer
2023-09-23 5:19 ` kernel test robot [this message]
2023-09-21 12:09 ` [PATCH bpf-next v5 4/9] bpf: Implement cgroup sockaddr hooks for unix sockets Daan De Meyer
2023-09-22 21:18 ` Martin KaFai Lau
2023-09-25 22:12 ` Jordan Rife
2023-09-26 9:54 ` Daan De Meyer
2023-09-26 20:20 ` Jordan Rife
2023-09-21 12:09 ` [PATCH bpf-next v5 5/9] libbpf: Add support for cgroup unix socket address hooks Daan De Meyer
2023-09-21 12:09 ` [PATCH bpf-next v5 6/9] bpftool: " Daan De Meyer
2023-09-25 12:45 ` Quentin Monnet
2023-09-21 12:09 ` [PATCH bpf-next v5 7/9] documentation/bpf: Document " Daan De Meyer
2023-09-21 12:09 ` [PATCH bpf-next v5 8/9] selftests/bpf: Make sure mount directory exists Daan De Meyer
2023-09-21 12:09 ` [PATCH bpf-next v5 9/9] selftests/bpf: Add tests for cgroup unix socket address hooks Daan De Meyer
2023-09-22 22:04 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309231339.L2O0CrMU-lkp@intel.com \
--to=lkp@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daan.j.demeyer@gmail.com \
--cc=kernel-team@meta.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).