From: Simon Horman <horms@kernel.org>
To: Jordan Rife <jrife@google.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, willemdebruijn.kernel@gmail.com,
netdev@vger.kernel.org, dborkman@kernel.org, pablo@netfilter.org,
kadlec@netfilter.org, fw@strlen.de, santosh.shilimkar@oracle.com,
ast@kernel.org, rdna@fb.com, stable@vger.kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net v5 1/3] net: replace calls to sock->ops->connect() with kernel_connect()
Date: Wed, 27 Sep 2023 07:50:33 +0200 [thread overview]
Message-ID: <20230927055033.GB224399@kernel.org> (raw)
In-Reply-To: <20230921234642.1111903-1-jrife@google.com>
On Thu, Sep 21, 2023 at 06:46:40PM -0500, Jordan Rife wrote:
> commit 0bdf399342c5 ("net: Avoid address overwrite in kernel_connect")
> ensured that kernel_connect() will not overwrite the address parameter
> in cases where BPF connect hooks perform an address rewrite. This change
> replaces direct calls to sock->ops->connect() in net with kernel_connect()
> to make these call safe.
>
> Link: https://lore.kernel.org/netdev/20230912013332.2048422-1-jrife@google.com/
> Fixes: d74bad4e74ee ("bpf: Hooks for sys_connect")
> Cc: stable@vger.kernel.org
> Reviewed-by: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Jordan Rife <jrife@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-09-27 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 23:46 [PATCH net v5 1/3] net: replace calls to sock->ops->connect() with kernel_connect() Jordan Rife
2023-09-21 23:46 ` [PATCH net v5 2/3] net: prevent rewrite of msg_name in sock_sendmsg() Jordan Rife
2023-09-27 5:50 ` Simon Horman
2023-09-21 23:46 ` [PATCH net v5 3/3] net: prevent address rewrite in kernel_bind() Jordan Rife
2023-09-27 5:51 ` Simon Horman
2023-09-27 5:50 ` Simon Horman [this message]
2023-10-01 18:40 ` [PATCH net v5 1/3] net: replace calls to sock->ops->connect() with kernel_connect() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927055033.GB224399@kernel.org \
--to=horms@kernel.org \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=dborkman@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jrife@google.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=rdna@fb.com \
--cc=santosh.shilimkar@oracle.com \
--cc=stable@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).