From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A43BD1118 for ; Thu, 28 Sep 2023 12:36:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D90D4C433C8; Thu, 28 Sep 2023 12:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695904584; bh=IFrcf1HPc0zyK3iLaNG9gOuBji+30hPiT2IlRSdShVg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SmmsEIeoEjtbXkbPElRqp9gu3YYdGTtyOl6LSOrsqPNKvrJFBRvd4hunEGDSG6ofF ovLsJsACNdNoUM4hd6kEo9as/IwAqEZguEWwjdD6NwPRcTMTh+p6xqSvR4RIvgJgu+ YmjfMwTxsHXWApRPheJwSj8gVnxWb1CeGP6xT59uHhTjqji5ALA12XRlmJ+pBNfi5g oOPIT6PW5FOMaMZhmhxwhMNd4QU9BAyiKGefbOXgW/CyHLHiQFByktsIztcvENhPAK mwBfGB3UiLqiOg4YWK0090U7eqQduQWo92OJ/J82nX/Ki0ClHfZvG3bsLx2pzrH2Jq dPtXVfiCHHfBA== Date: Thu, 28 Sep 2023 14:35:56 +0200 From: Simon Horman To: Miquel Raynal Cc: Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, linux-can@vger.kernel.org, =?utf-8?B?SsOpcsOpbWll?= Dautheribes , Thomas Petazzoni , sylvain.girard@se.com, pascal.eberhard@se.com Subject: Re: [PATCH net-next] can: sja1000: Fix comment Message-ID: <20230928123556.GH24230@kernel.org> References: <20230922155130.592187-1-miquel.raynal@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922155130.592187-1-miquel.raynal@bootlin.com> On Fri, Sep 22, 2023 at 05:51:30PM +0200, Miquel Raynal wrote: > There is likely a copy-paste error here, as the exact same comment > appears below in this function, one time calling set_reset_mode(), the > other set_normal_mode(). > > Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller") I'm not sure this warrants a fixes tag, which implies backporting, but in any case the tag is correct. > Signed-off-by: Miquel Raynal The above comment notwithstanding, this seems correct to me. Reviewed-by: Simon Horman