From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74AFA168CA for ; Sat, 30 Sep 2023 18:30:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 110ACC433C7; Sat, 30 Sep 2023 18:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696098602; bh=Y4imC89W3KdMY2UPdzMV4XPUqHsU4iC+LIa8tI7NQ8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1RyzUb0dql97BmSTWWXH4WElBuESRh1nfdjAYmTH6vuLq7CQYn81zMxLMOFAd/clX iF+kliizT2sMMAonxvxRvneMRkqHLihK8T/2wT2afNvjL8A1K1mlo4KXLJcHHMSGmr Y47tDVyqgVi4Hl20otmWlcRMF8i+XqmAWjqicUL0= Date: Sat, 30 Sep 2023 20:29:59 +0200 From: Greg Kroah-Hartman To: Jerry Snitselaar Cc: Chris Leech , Christoph Hellwig , Rasesh Mody , Ariel Elior , Sudarsana Kalluru , Manish Chopra , Nilesh Javali , Manish Rangankar , John Meneghini , Lee Duncan , Mike Christie , Hannes Reinecke , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] cnic,bnx2,bnx2x: use UIO_MEM_DMA_COHERENT Message-ID: <2023093003-city-pursuant-956e@gregkh> References: <20230929170023.1020032-1-cleech@redhat.com> <20230929170023.1020032-4-cleech@redhat.com> <2023093055-gotten-astronomy-a98b@gregkh> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Sep 30, 2023 at 02:10:50AM -0700, Jerry Snitselaar wrote: > [1] https://github.com/open-iscsi/open-iscsi/blob/master/iscsiuio/README That's IP offload, not what UIO is supposed to be for at all (yes, I know DPDK abuses this api as well, and I hate it.) But this is on a network card, it shouldn't need UIO. Why is iscsi somehow "special" for this? still confused, greg k-h