From: Jakub Kicinski <kuba@kernel.org>
To: Sven Auhagen <sven.auhagen@voleatech.de>
Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com,
hawk@kernel.org, lorenzo@kernel.org, Paulo.DaSilva@kyberna.com,
ilias.apalodimas@linaro.org, mcroce@linux.microsoft.com
Subject: Re: [PATCH v2 1/2] net: page_pool: check page pool ethtool stats
Date: Mon, 2 Oct 2023 12:46:50 -0700 [thread overview]
Message-ID: <20231002124650.7f01e1e6@kernel.org> (raw)
In-Reply-To: <abr3xq5eankrmzvyhjd5za6itfm5s7wpqwfy7lp3iuwsv33oi3@dx5eg6wmb2so>
On Sun, 1 Oct 2023 13:41:15 +0200 Sven Auhagen wrote:
> If the page_pool variable is null while passing it to
> the page_pool_get_stats function we receive a kernel error.
>
> Check if the page_pool variable is at least valid.
IMHO this seems insufficient, the driver still has to check if PP
was instantiated when the strings are queried. My weak preference
would be to stick to v1 and have the driver check all the conditions.
But if nobody else feels this way, it's fine :)
next prev parent reply other threads:[~2023-10-02 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 11:41 [PATCH v2 1/2] net: page_pool: check page pool ethtool stats Sven Auhagen
2023-10-02 19:46 ` Jakub Kicinski [this message]
2023-10-03 4:12 ` Sven Auhagen
2023-10-25 5:59 ` Ilias Apalodimas
2023-10-25 7:53 ` Leon Romanovsky
2023-10-30 9:39 ` Sven Auhagen
2023-10-30 14:23 ` Leon Romanovsky
2023-10-30 14:42 ` Sven Auhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002124650.7f01e1e6@kernel.org \
--to=kuba@kernel.org \
--cc=Paulo.DaSilva@kyberna.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo@kernel.org \
--cc=mcroce@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sven.auhagen@voleatech.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).