From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Lukasz Majewski <lukma@denx.de>,
Tristram.Ha@microchip.com, Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, Woojung Huh <woojung.huh@microchip.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
UNGLinuxDriver@microchip.com,
Oleksij Rempel <linux@rempel-privat.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW offloading for KSZ9477
Date: Tue, 3 Oct 2023 06:34:01 -0700 [thread overview]
Message-ID: <20231003063401.5fc0ffb9@kernel.org> (raw)
In-Reply-To: <20230911170222.hip2pcyzbfu3olau@skbuf>
On Mon, 11 Sep 2023 20:02:22 +0300 Vladimir Oltean wrote:
> Hi @Jakub, I remember you fixed some issues with the dev->dev_addr writes,
> after dev_addr_lists.c was changed to a rbtree. Is it easy for you to
> tell if the change below is safe from an API perspective?
>
> Is the answer "yes, because dev_uc_add() uses an addr_type of NETDEV_HW_ADDR_T_UNICAST,
> and dev->dev_addr uses NETDEV_HW_ADDR_T_LAN, so they never share a struct netdev_hw_addr
> for the same MAC address, and thus, they never collide"?
>
> The DSA and 8021q drivers currently have this pattern, from around 2008.
> But 8021q also tracks NETDEV_CHANGEADDR events on the real_dev, which is
> absent in DSA. If the change below is safe, it would be a simpler solution.
FWIW I think it should be fine from the rbtree perspective, but IDK how
the user space would react to having a duplicate lladdr.
next prev parent reply other threads:[~2023-10-03 13:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 15:27 [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW offloading for KSZ9477 Lukasz Majewski
2023-09-06 15:28 ` [[RFC PATCH v4 net-next] 1/2] net: dsa: Extend ksz9477 TAG setup to support HSR frames duplication Lukasz Majewski
2023-09-06 15:28 ` [[RFC PATCH v4 net-next] 2/2] net: dsa: hsr: Enable in KSZ9477 switch HW HSR offloading Lukasz Majewski
2023-09-11 14:58 ` [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW offloading for KSZ9477 Lukasz Majewski
2023-09-11 16:05 ` Vladimir Oltean
2023-09-11 17:02 ` Vladimir Oltean
2023-09-11 17:03 ` Vladimir Oltean
2023-10-03 13:34 ` Jakub Kicinski [this message]
2023-09-12 8:17 ` Lukasz Majewski
2023-09-12 9:29 ` Vladimir Oltean
2023-09-12 14:03 ` Lukasz Majewski
2023-09-12 14:26 ` Vladimir Oltean
2023-09-12 15:06 ` Lukasz Majewski
2023-09-12 21:55 ` Vladimir Oltean
2023-09-13 8:22 ` Lukasz Majewski
2023-09-13 10:58 ` Vladimir Oltean
2023-09-13 12:15 ` Lukasz Majewski
2023-09-13 13:51 ` Vladimir Oltean
2023-09-13 18:42 ` Vladimir Oltean
2023-09-14 21:18 ` Lukasz Majewski
2023-09-15 14:22 ` Vladimir Oltean
2023-09-18 9:06 ` Lukasz Majewski
2023-09-14 20:45 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003063401.5fc0ffb9@kernel.org \
--to=kuba@kernel.org \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).