From: Jakub Kicinski <kuba@kernel.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Woojung Huh <woojung.huh@microchip.com>,
Tristram.Ha@microchip.com, Eric Dumazet <edumazet@google.com>,
davem@davemloft.net, Oleksij Rempel <o.rempel@pengutronix.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 net-next 0/5] net: dsa: hsr: Enable HSR HW offloading for KSZ9477
Date: Tue, 3 Oct 2023 06:42:13 -0700 [thread overview]
Message-ID: <20231003064213.4886626f@kernel.org> (raw)
In-Reply-To: <20231003145106.3cd5a19f@wsk>
On Tue, 3 Oct 2023 14:51:06 +0200 Lukasz Majewski wrote:
> I've just noticed that there is a WARNING:
> https://patchwork.kernel.org/project/netdevbpf/patch/20230922133108.2090612-6-lukma@denx.de/
>
> but then on the newest kernel checkpatch.pl is silent:
> ./scripts/checkpatch.pl
> 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch total: 0
> errors, 0 warnings, 0 checks, 277 lines checked
>
> 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch has no
> obvious style problems and is ready for submission.
>
> Does the checkpatch for patchwork differs in any way from mainline?
We run:
checkpatch with --strict --max-line-length=80
https://github.com/kuba-moo/nipa/blob/master/tests/patch/checkpatch/checkpatch.sh
The "multiple new lines" warning on patch 2 looks legit, no?
next prev parent reply other threads:[~2023-10-03 13:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 13:31 [PATCH v6 net-next 0/5] net: dsa: hsr: Enable HSR HW offloading for KSZ9477 Lukasz Majewski
2023-09-22 13:31 ` [PATCH v6 net-next 1/5] net: dsa: propagate extack to ds->ops->port_hsr_join() Lukasz Majewski
2023-09-26 22:44 ` Vladimir Oltean
2023-09-22 13:31 ` [PATCH v6 net-next 2/5] net: dsa: notify drivers of MAC address changes on user ports Lukasz Majewski
2023-09-22 13:31 ` [PATCH v6 net-next 3/5] net: dsa: tag_ksz: Extend ksz9477_xmit() for HSR frame duplication Lukasz Majewski
2023-09-22 13:31 ` [PATCH v6 net-next 4/5] net: dsa: microchip: move REG_SW_MAC_ADDR to dev->info->regs[] Lukasz Majewski
2023-09-22 13:31 ` [PATCH v6 net-next 5/5] net: dsa: microchip: Enable HSR offloading for KSZ9477 Lukasz Majewski
2023-09-26 22:54 ` [PATCH v6 net-next 0/5] net: dsa: hsr: Enable HSR HW " Vladimir Oltean
2023-09-28 10:41 ` Lukasz Majewski
2023-10-03 7:58 ` Lukasz Majewski
2023-10-03 10:44 ` Vladimir Oltean
2023-10-03 12:51 ` Lukasz Majewski
2023-10-03 13:42 ` Jakub Kicinski [this message]
2023-10-03 14:15 ` Lukasz Majewski
2024-01-09 12:32 ` [net][hsr] Question regarding HSR RedBox functionality implementation (preferably on KSZ9477) Lukasz Majewski
2024-01-09 12:52 ` Vladimir Oltean
2024-01-09 14:04 ` Lukasz Majewski
2024-02-14 10:44 ` Lukasz Majewski
2024-02-15 11:51 ` Lukasz Majewski
2024-02-15 17:23 ` Stephen Hemminger
2023-10-03 13:50 ` [PATCH v6 net-next 0/5] net: dsa: hsr: Enable HSR HW offloading for KSZ9477 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003064213.4886626f@kernel.org \
--to=kuba@kernel.org \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).