From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
Alan Brady <alan.brady@intel.com>,
"Sridhar Samudrala" <sridhar.samudrala@intel.com>,
Willem de Bruijn <willemb@google.com>,
Phani Burra <phani.r.burra@intel.com>,
Joshua Hay <joshua.a.hay@intel.com>,
Pavan Kumar Linga <pavan.kumar.linga@intel.com>,
Madhu Chittim <madhu.chittim@intel.com>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH] idpf: fix building without IPv4
Date: Tue, 3 Oct 2023 15:43:26 -0700 [thread overview]
Message-ID: <20231003154326.213e9c81@kernel.org> (raw)
In-Reply-To: <1430f3d3-4e84-b0ec-acd9-8a51db178f73@intel.com>
On Mon, 25 Sep 2023 10:05:03 -0700 Tony Nguyen wrote:
> Also, a pending patch for this [1], however, this does look a bit more
> efficient. Adding Olek as he's author on the other patch.
>
> netdev maintainers,
>
> If this is the version that does get picked up, did you want to take it
> directly to close out the compile issues?
Sorry for the delays. Should we not add a !INET static inline wrapper
for tcp_gro_complete()? Seems a bit backwards to me to make drivers
suffer and think about such a preposterous config :S
$ git grep tcp_gro_complete -- drivers/
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c: tcp_gro_complete(skb);
drivers/net/ethernet/broadcom/bnxt/bnxt.c: tcp_gro_complete(skb);
drivers/net/ethernet/intel/idpf/idpf_txrx.c: tcp_gro_complete(skb);
drivers/net/ethernet/qlogic/qede/qede_fp.c: tcp_gro_complete(skb);
We have 4 drivers which need ifdefs already and the number will only
grow with GRO-HW spreading.
next prev parent reply other threads:[~2023-10-03 22:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 15:58 [PATCH] idpf: fix building without IPv4 Arnd Bergmann
2023-09-25 17:05 ` Tony Nguyen
2023-10-03 22:43 ` Jakub Kicinski [this message]
2023-10-04 8:25 ` Arnd Bergmann
2023-10-04 8:50 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003154326.213e9c81@kernel.org \
--to=kuba@kernel.org \
--cc=alan.brady@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=phani.r.burra@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).