From: Jakub Kicinski <kuba@kernel.org>
To: Vishvambar Panth S <vishvambarpanth.s@microchip.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<bryan.whitehead@microchip.com>, <unglinuxdriver@microchip.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<richardcochran@gmail.com>
Subject: Re: [PATCH net-next] net: microchip: lan743x: improve throughput with rx timestamp config
Date: Wed, 4 Oct 2023 11:00:31 -0700 [thread overview]
Message-ID: <20231004110031.7e9c32e8@kernel.org> (raw)
In-Reply-To: <20230926155658.159184-1-vishvambarpanth.s@microchip.com>
On Tue, 26 Sep 2023 21:26:58 +0530 Vishvambar Panth S wrote:
> + netif_warn(adapter, drv, adapter->netdev,
> + "rx timestamp = %d is not supported\n",
> + rx_filter);
I addition to Jake's comments please also drop this warning.
> + return -EINVAL;
And make sure this is the correct return code.
I thought -ERANGE was more appropriate here, but I could be wrong.
next prev parent reply other threads:[~2023-10-04 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 15:56 [PATCH net-next] net: microchip: lan743x: improve throughput with rx timestamp config Vishvambar Panth S
2023-09-26 23:48 ` Jacob Keller
2023-10-05 10:58 ` VishvambarPanth.S
2023-10-04 18:00 ` Jakub Kicinski [this message]
2023-10-05 11:02 ` VishvambarPanth.S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004110031.7e9c32e8@kernel.org \
--to=kuba@kernel.org \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=unglinuxdriver@microchip.com \
--cc=vishvambarpanth.s@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).