From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Vishvambar Panth S <vishvambarpanth.s@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew@lunn.ch
Subject: Re: [PATCH net] net: microchip: lan743x : bidirectional throughuput improvement
Date: Wed, 4 Oct 2023 13:09:57 -0700 [thread overview]
Message-ID: <20231004130957.2d633d03@kernel.org> (raw)
In-Reply-To: <b1f64c44-0d1c-480e-a272-fb017e7d8673@gmail.com>
On Wed, 4 Oct 2023 13:02:17 -0700 Florian Fainelli wrote:
> > Nobody complained for 5 years, and it's not a regression.
> > Let's not treat this as a fix, please repost without the Fixes tag for
> > net-next.
>
> As a driver maintainer, you may want to provide some guarantees to your
> end users/customers that from stable version X.Y.Z the performance
> issues have been fixed. Performance improvements are definitively border
> line in terms of being considered as bug fixes though.
I understand that, but too often people just "feel like a device which
advertises X Mbps / Gbps should reach line rate" while no end user
cares.
Luckily stable rules are pretty clear about this (search for
"performance"):
https://docs.kernel.org/process/stable-kernel-rules.html
As posted it doesn't fulfill the requirements 🤷️
next prev parent reply other threads:[~2023-10-04 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 11:16 [PATCH net] net: microchip: lan743x : bidirectional throughuput improvement Vishvambar Panth S
2023-09-29 17:35 ` Jacob Keller
2023-10-05 5:17 ` VishvambarPanth.S
2023-10-04 19:20 ` Jakub Kicinski
2023-10-04 20:02 ` Florian Fainelli
2023-10-04 20:09 ` Jakub Kicinski [this message]
2023-11-01 7:20 ` VishvambarPanth.S
2023-11-09 10:53 ` VishvambarPanth.S
2023-11-09 23:04 ` Jakub Kicinski
2023-11-16 5:49 ` VishvambarPanth.S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004130957.2d633d03@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vishvambarpanth.s@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).