From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: <edward.cree@amd.com>, <linux-net-drivers@amd.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
Edward Cree <ecree.xilinx@gmail.com>, <netdev@vger.kernel.org>,
<habetsm.xilinx@gmail.com>, <sudheer.mogilappagari@intel.com>,
<jdamato@fastly.com>, <andrew@lunn.ch>, <mw@semihalf.com>,
<linux@armlinux.org.uk>, <sgoutham@marvell.com>,
<gakula@marvell.com>, <sbhatta@marvell.com>, <hkelam@marvell.com>,
<saeedm@nvidia.com>, <leon@kernel.org>
Subject: Re: [PATCH v4 net-next 2/7] net: ethtool: attach an XArray of custom RSS contexts to a netdevice
Date: Wed, 4 Oct 2023 15:56:55 -0700 [thread overview]
Message-ID: <20231004155655.470845fb@kernel.org> (raw)
In-Reply-To: <781cf46c-bbcc-5223-76b8-176c7bf5836d@intel.com>
On Fri, 29 Sep 2023 11:17:53 -0700 Jacob Keller wrote:
> > +struct ethtool_rxfh_context {
> > + u32 indir_size;
> > + u32 key_size;
> > + u8 hfunc;
> > + u16 priv_size;
> > + u8 indir_no_change:1;
> > + u8 key_no_change:1;
> > + /* private: driver private data, indirection table, and hash key are
> > + * stored sequentially in @data area. Use below helpers to access.
> > + */
> > + u8 data[] __aligned(sizeof(void *));
> > +};
>
> Is it not feasible to use container_of to get to private data for the
> drivers? I guess this change in particular doesn't actually include any
> users yet...
That could work in general but here specifically there are also
2 variable-size arrays hiding in data[].
next prev parent reply other threads:[~2023-10-04 22:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 18:13 [PATCH v4 net-next 0/7] ethtool: track custom RSS contexts in the core edward.cree
2023-09-27 18:13 ` [PATCH v4 net-next 1/7] net: move ethtool-related netdev state into its own struct edward.cree
2023-09-29 18:15 ` Jacob Keller
2023-10-02 9:59 ` Martin Habets
2023-09-27 18:13 ` [PATCH v4 net-next 2/7] net: ethtool: attach an XArray of custom RSS contexts to a netdevice edward.cree
2023-09-29 18:17 ` Jacob Keller
2023-10-04 22:56 ` Jakub Kicinski [this message]
2023-09-29 20:59 ` Mogilappagari, Sudheer
2023-10-02 10:23 ` Martin Habets
2023-10-04 23:00 ` Jakub Kicinski
2023-10-05 18:32 ` Edward Cree
2023-10-04 23:10 ` Jakub Kicinski
2023-10-05 18:43 ` Edward Cree
2023-10-05 23:53 ` Jakub Kicinski
2023-09-27 18:13 ` [PATCH v4 net-next 3/7] net: ethtool: record custom RSS contexts in the XArray edward.cree
2023-09-29 18:20 ` Jacob Keller
2023-10-02 10:41 ` Martin Habets
2023-09-27 18:13 ` [PATCH v4 net-next 4/7] net: ethtool: let the core choose RSS context IDs edward.cree
2023-09-29 18:23 ` Jacob Keller
2023-10-02 10:54 ` Martin Habets
2023-09-27 18:13 ` [PATCH v4 net-next 5/7] net: ethtool: add an extack parameter to new rxfh_context APIs edward.cree
2023-09-29 18:24 ` Jacob Keller
2023-10-02 12:13 ` Martin Habets
2023-09-27 18:13 ` [PATCH v4 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts edward.cree
2023-09-29 18:27 ` Jacob Keller
2023-10-02 12:16 ` Martin Habets
2023-10-04 23:16 ` Jakub Kicinski
2023-10-05 20:56 ` Edward Cree
2023-10-06 0:07 ` Jakub Kicinski
2023-12-07 14:15 ` Edward Cree
2023-12-07 16:45 ` Jakub Kicinski
2023-09-27 18:13 ` [PATCH v4 net-next 7/7] sfc: use new rxfh_context API edward.cree
2023-09-29 18:27 ` Jacob Keller
2023-10-02 13:01 ` Martin Habets
2023-10-05 20:54 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004155655.470845fb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=gakula@marvell.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hkelam@marvell.com \
--cc=jacob.e.keller@intel.com \
--cc=jdamato@fastly.com \
--cc=leon@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).