From: Jakub Kicinski <kuba@kernel.org>
To: Robert Marko <robimarko@gmail.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Christian Marangi <ansuelsmth@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [RFC PATCH net-next] net: phy: aquantia: add firmware load support
Date: Wed, 4 Oct 2023 16:28:31 -0700 [thread overview]
Message-ID: <20231004162831.0cf1f6a8@kernel.org> (raw)
In-Reply-To: <20230930104008.234831-1-robimarko@gmail.com>
On Sat, 30 Sep 2023 12:39:44 +0200 Robert Marko wrote:
> + ret = of_property_read_string(dev->of_node, "firmware-name",
> + &fw_name);
Perhaps a well established weirdness of the embedded world but why read
the fw name from OF?! You can identify what PHY it is and decide the
file name based on that. And also put that fw name in MODULE_FIRMWARE()
so that initramfs can be built with appropriate file in place :S
> + ret = request_firmware(&fw, fw_name, dev);
next prev parent reply other threads:[~2023-10-04 23:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 10:39 [RFC PATCH net-next] net: phy: aquantia: add firmware load support Robert Marko
2023-10-02 20:18 ` Andrew Lunn
2023-10-02 20:22 ` Christian Marangi
2023-10-02 21:07 ` Andrew Lunn
2023-10-03 10:21 ` Christian Marangi
2023-10-03 15:20 ` Simon Horman
2023-10-04 23:28 ` Jakub Kicinski [this message]
2023-10-05 2:43 ` Andrew Lunn
2023-10-05 14:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004162831.0cf1f6a8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).