Re: [PATCH v2 1/3] rust: core abstractions for network PHY drivers

Trevor Gross
2023-10-08T08:55:07Z

On Sun, Oct 8, 2023 at 3:49 AM FUJITA Tomonori
<fujita.tomonori@gmail.com> wrote:
> I realized that we don't need `name`. The name of struct doesn't
> matter so I use `Module`. I tried to use `name` for the name of
> device_table however the variable name of the table isn't embeded into
> the module binary so it doesn't matter.
>
> FYI, I use paste! but got the following error:
>
> = help: message: `"__mod_mdio__\"rust_asix_phy\"_device_table"` is not a valid identifier
> = note: this error originates in the macro `$crate::module_phy_driver` which comes from the expansion of the
> macro `kernel::module_phy_driver` (in Nightly builds, run with -Z macro-backtrace for more info)

Too bad, this seems to be a limitation of our paste macro compared to
the published one. What you have with `Module` seems fine so I think
you don't need it?

I'll submit a patch to fix paste sometime this week, don't wait on it
though of course.