From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, jesse.brandeburg@intel.com,
sd@queasysnail.net, horms@verge.net.au
Subject: Re: [RFC] docs: netdev: encourage reviewers
Date: Fri, 6 Oct 2023 11:57:15 -0700 [thread overview]
Message-ID: <20231006115715.4f718fd7@kernel.org> (raw)
In-Reply-To: <8270f9b2-ec07-4f07-86cf-425d25829453@lunn.ch>
On Fri, 6 Oct 2023 20:41:19 +0200 Andrew Lunn wrote:
> We already have:
>
> https://docs.kernel.org/process/7.AdvancedTopics.html#reviewing-patches
>
> which has some of the same concepts. I don't think anything in the
> proposed new text is specific to netdev, unlike most of the rest of
> maintainer-netdev.rst which does reference netdev specific rules or
> concepts.
>
> So i wounder if this even belongs in netdev? Do we actually want to
> extend the current text in "A guide to the Kernel Development
> Process", and maintainer-netdev.rst say something like:
>
> Reviewing other people's patches on the list is highly encouraged,
> regardless of the level of expertise.
>
> and cross reference to the text in section 7.2?
:) If I can't get it past you there's no chance I'll get it past docs@
Let me move some of the staff into general docs and add a reference.
The questions which came up were about use of tags and how maintainers
approach the reviews from less experienced devs, which I think is
subsystem-specific?
next prev parent reply other threads:[~2023-10-06 18:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 16:30 [RFC] docs: netdev: encourage reviewers Jakub Kicinski
2023-10-06 16:38 ` Edward Cree
2023-10-06 16:42 ` Florian Fainelli
2023-10-06 16:59 ` Jiri Pirko
2023-10-06 18:41 ` Andrew Lunn
2023-10-06 18:57 ` Jakub Kicinski [this message]
2023-10-06 19:10 ` Jakub Kicinski
2023-10-06 19:36 ` Andrew Lunn
2023-10-06 21:21 ` Florian Fainelli
2023-10-09 15:13 ` Przemek Kitszel
2023-10-09 16:13 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006115715.4f718fd7@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@verge.net.au \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).