From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19847450C9 for ; Fri, 6 Oct 2023 22:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B838BD for ; Fri, 6 Oct 2023 15:14:11 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qot5E-0002xA-9Y; Sat, 07 Oct 2023 00:14:08 +0200 Date: Sat, 7 Oct 2023 00:14:08 +0200 From: Florian Westphal To: Willem de Bruijn Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, alexander.duyck@gmail.com, fw@strlen.de, Willem de Bruijn Subject: Re: [PATCH net-next 3/3] net: expand skb_segment unit test with frag_list coverage Message-ID: <20231006221408.GA11182@breakpoint.cc> References: <20231005134917.2244971-1-willemdebruijn.kernel@gmail.com> <20231005134917.2244971-4-willemdebruijn.kernel@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231005134917.2244971-4-willemdebruijn.kernel@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Willem de Bruijn wrote: > + /* TODO: this should also work with SG, > + * rather than hit BUG_ON(i >= nfrags) > + */ > + if (tcase->id == GSO_TEST_FRAG_LIST_NON_UNIFORM) > + features &= ~NETIF_F_SG; Out of curiosity, this can't be hit outside of this test because GRO is only source and won't generate skbs that would trigger this, correct?