netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	edumazet@google.com, pabeni@redhat.com,
	alexander.duyck@gmail.com, fw@strlen.de,
	Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next 0/3] add skb_segment kunit coverage
Date: Sat, 7 Oct 2023 00:14:42 +0200	[thread overview]
Message-ID: <20231006221442.GE29258@breakpoint.cc> (raw)
In-Reply-To: <20231005134917.2244971-1-willemdebruijn.kernel@gmail.com>

Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
> As discussed at netconf last week. Some kernel code is exercised in
> many different ways. skb_segment is a prime example. This ~350 line
> function has 49 different patches in git blame with 28 different
> authors.

Thanks for this work, and especially for adding commit ids
for relevant features that are tested.

Reviewed-by: Florian Westphal <fw@strlen.de>

  parent reply	other threads:[~2023-10-06 22:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05 13:48 [PATCH net-next 0/3] add skb_segment kunit coverage Willem de Bruijn
2023-10-05 13:48 ` [PATCH net-next 1/3] net: add skb_segment kunit test Willem de Bruijn
2023-10-05 13:48 ` [PATCH net-next 2/3] net: parametrize skb_segment unit test to expand coverage Willem de Bruijn
2023-10-05 13:48 ` [PATCH net-next 3/3] net: expand skb_segment unit test with frag_list coverage Willem de Bruijn
2023-10-06 22:14   ` Florian Westphal
2023-10-07  8:58     ` Willem de Bruijn
2023-10-06 22:14 ` Florian Westphal [this message]
2023-10-07  0:30 ` [PATCH net-next 0/3] add skb_segment kunit coverage Jakub Kicinski
2023-10-07  9:02   ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006221442.GE29258@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).