From: Florian Westphal <fw@strlen.de>
To: George Guo <dongtai.guo@linux.dev>
Cc: edumazet@google.com, davem@davemloft.net, dsahern@kernel.org,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, George Guo <guodongtai@kylinos.cn>
Subject: Re: [PATCH] tcp: fix secure_{tcp, tcpv6}_ts_off call parameter order mistake
Date: Sat, 7 Oct 2023 12:50:19 +0200 [thread overview]
Message-ID: <20231007105019.GA20662@breakpoint.cc> (raw)
In-Reply-To: <20231007092337.1540036-1-dongtai.guo@linux.dev>
George Guo <dongtai.guo@linux.dev> wrote:
> From: George Guo <guodongtai@kylinos.cn>
>
> Fix secure_tcp_ts_off and secure_tcpv6_ts_off call parameter order mistake
Could you please send a v2, targetting net-next, that clearly
says that this is a cleanup?
[ It doesn't matter if we pass "saddr, daddr" or
"daddr, saddr" as long as both "init" and "check"
functions agree on the ordering ]
next prev parent reply other threads:[~2023-10-07 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 9:23 [PATCH] tcp: fix secure_{tcp, tcpv6}_ts_off call parameter order mistake George Guo
2023-10-07 10:50 ` Florian Westphal [this message]
2023-10-09 2:11 ` [PATCH v2] tcp: cleanup secure_{tcp, tcpv6}_ts_off George Guo
2023-10-09 7:18 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231007105019.GA20662@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=dongtai.guo@linux.dev \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=guodongtai@kylinos.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).